summaryrefslogtreecommitdiff
path: root/remote.c
diff options
context:
space:
mode:
authorRené Scharfe <l.s.r@web.de>2014-06-06 19:24:48 +0200
committerJunio C Hamano <gitster@pobox.com>2014-06-09 14:38:12 -0700
commit50e19a83585bd1aeae6aa01d31e5f783b7ef8b1b (patch)
tree37c4a5fad81436a9afc07e87486a26ec8b0b9e9b /remote.c
parentbce14aa132e0064d9a9b1c7ad98e71e22c6e0272 (diff)
downloadgit-50e19a83585bd1aeae6aa01d31e5f783b7ef8b1b.tar.gz
Use starts_with() for C strings instead of memcmp()rs/more-starts-with
Convert three cases of checking for a constant prefix using memcmp() to starts_with(). This way there is no need for magic string length constants and we avoid running over the end of the string should it be shorter than the prefix. Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'remote.c')
-rw-r--r--remote.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/remote.c b/remote.c
index eea2c8de45..0f6ef36b7d 100644
--- a/remote.c
+++ b/remote.c
@@ -1194,7 +1194,7 @@ static int match_explicit(struct ref *src, struct ref *dst,
case 1:
break;
case 0:
- if (!memcmp(dst_value, "refs/", 5))
+ if (starts_with(dst_value, "refs/"))
matched_dst = make_linked_ref(dst_value, dst_tail);
else if (is_null_sha1(matched_src->new_sha1))
error("unable to delete '%s': remote ref does not exist",