summaryrefslogtreecommitdiff
path: root/remote-curl.c
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2013-04-05 18:21:14 -0400
committerJunio C Hamano <gitster@pobox.com>2013-04-06 18:56:43 -0700
commitd5ccbe4dfb43d95d1d04252490fcd200e6aa5759 (patch)
tree699809f2108cf46c92d429110a43b45cfcbada29 /remote-curl.c
parentcfa0f4040dd1885fbcdd3d306c1defe22d0fee00 (diff)
downloadgit-d5ccbe4dfb43d95d1d04252490fcd200e6aa5759.tar.gz
remote-curl: consistently report repo url for http errors
When we report http errors in fetching the initial ref advertisement, we show the full URL we attempted to use, including "info/refs?service=git-upload-pack". While this may be useful for debugging a broken server, it is unnecessarily verbose and confusing for most cases, in which the client user is not even the same person as the owner of the repository. Let's just show the repository URL; debugging can happen with GIT_CURL_VERBOSE, which shows way more useful information, anyway. At the same time, let's also make sure to mention the repository URL when we report failed authentication (previously we said only "Authentication failed"). Knowing the URL can help the user realize why authentication failed (e.g., they meant to push to remote A, not remote B). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'remote-curl.c')
-rw-r--r--remote-curl.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/remote-curl.c b/remote-curl.c
index 5d9f9618b4..6c6714b00a 100644
--- a/remote-curl.c
+++ b/remote-curl.c
@@ -213,10 +213,10 @@ static struct discovery* discover_refs(const char *service, int for_push)
die("repository '%s' not found", url);
case HTTP_NOAUTH:
show_http_message(&type, &buffer);
- die("Authentication failed");
+ die("Authentication failed for '%s'", url);
default:
show_http_message(&type, &buffer);
- http_error(refs_url, http_ret);
+ http_error(url, http_ret);
die("HTTP request failed");
}