diff options
| author | Denton Liu <liu.denton@gmail.com> | 2019-04-29 04:28:14 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2019-05-05 15:20:06 +0900 |
| commit | 554544276a604c144df45efcb060c80aa322088c (patch) | |
| tree | ce55b3dc9ca47c326991ecfc06a2b1103f60be3a /pkt-line.h | |
| parent | ffac537e6cbbf934b08745a378932722df287a53 (diff) | |
| download | git-554544276a604c144df45efcb060c80aa322088c.tar.gz | |
*.[ch]: remove extern from function declarations using spatch
There has been a push to remove extern from function declarations.
Remove some instances of "extern" for function declarations which are
caught by Coccinelle. Note that Coccinelle has some difficulty with
processing functions with `__attribute__` or varargs so some `extern`
declarations are left behind to be dealt with in a future patch.
This was the Coccinelle patch used:
@@
type T;
identifier f;
@@
- extern
T f(...);
and it was run with:
$ git ls-files \*.{c,h} |
grep -v ^compat/ |
xargs spatch --sp-file contrib/coccinelle/noextern.cocci --in-place
Files under `compat/` are intentionally excluded as some are directly
copied from external sources and we should avoid churning them as much
as possible.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'pkt-line.h')
| -rw-r--r-- | pkt-line.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/pkt-line.h b/pkt-line.h index c36cb788ed..1ebeaff236 100644 --- a/pkt-line.h +++ b/pkt-line.h @@ -172,7 +172,7 @@ struct packet_reader { * Initialize a 'struct packet_reader' object which is an * abstraction around the 'packet_read_with_status()' function. */ -extern void packet_reader_init(struct packet_reader *reader, int fd, +void packet_reader_init(struct packet_reader *reader, int fd, char *src_buffer, size_t src_len, int options); @@ -186,7 +186,7 @@ extern void packet_reader_init(struct packet_reader *reader, int fd, * 'line' is set to point at the read line * PACKET_READ_FLUSH: 'pktlen' is set to '0' and 'line' is set to NULL */ -extern enum packet_read_status packet_reader_read(struct packet_reader *reader); +enum packet_read_status packet_reader_read(struct packet_reader *reader); /* * Peek the next packet line without consuming it and return the status. @@ -196,7 +196,7 @@ extern enum packet_read_status packet_reader_read(struct packet_reader *reader); * Peeking multiple times without calling 'packet_reader_read()' will return * the same result. */ -extern enum packet_read_status packet_reader_peek(struct packet_reader *reader); +enum packet_read_status packet_reader_peek(struct packet_reader *reader); #define DEFAULT_PACKET_MAX 1000 #define LARGE_PACKET_MAX 65520 |