summaryrefslogtreecommitdiff
path: root/notes.c
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2011-03-29 16:56:53 -0400
committerJunio C Hamano <gitster@pobox.com>2011-03-29 14:30:54 -0700
commit304cc11c6566cf22e811aa791988c61b6d291973 (patch)
tree6fd82e26abd5019c134016a44b3f93566daca704 /notes.c
parentc063f0a973832784f09a6901eac9501b6f796bde (diff)
downloadgit-304cc11c6566cf22e811aa791988c61b6d291973.tar.gz
notes: refactor display notes extra refs field
There's no need to use an extra pointer, which just ends up leaking memory. The fact that the list is empty tells us the same thing. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'notes.c')
-rw-r--r--notes.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/notes.c b/notes.c
index f6b9b6a72a..2ec604c1db 100644
--- a/notes.c
+++ b/notes.c
@@ -1066,9 +1066,9 @@ void init_display_notes(struct display_notes_opt *opt)
git_config(notes_display_config, &load_config_refs);
- if (opt && opt->extra_notes_refs) {
+ if (opt) {
struct string_list_item *item;
- for_each_string_list_item(item, opt->extra_notes_refs)
+ for_each_string_list_item(item, &opt->extra_notes_refs)
string_list_add_refs_by_glob(&display_notes_refs,
item->string);
}