diff options
| author | Johan Herland <johan@herland.net> | 2009-03-26 16:16:47 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2009-03-27 22:10:58 -0700 |
| commit | fb8b193670b0c11d118185332efc899d6d01d5f4 (patch) | |
| tree | 1d25d46394067edd7833aeb70e714ebcbe6389c7 /http-push.c | |
| parent | 5a688fe4706462dfa0a7932ef0c82c335c47e9ab (diff) | |
| download | git-fb8b193670b0c11d118185332efc899d6d01d5f4.tar.gz | |
Move chmod(foo, 0444) into move_temp_to_file()
When writing out a loose object or a pack (index), move_temp_to_file() is
called to finalize the resulting file. These files (loose files and packs)
should all have permission mode 0444 (modulo adjust_shared_perm()).
Therefore, instead of doing chmod(foo, 0444) explicitly from each callsite
(or even forgetting to chmod() at all), do the chmod() call from within
move_temp_to_file().
Signed-off-by: Johan Herland <johan@herland.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'http-push.c')
| -rw-r--r-- | http-push.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/http-push.c b/http-push.c index 30d2d34041..968b6b0662 100644 --- a/http-push.c +++ b/http-push.c @@ -748,7 +748,6 @@ static void finish_request(struct transfer_request *request) aborted = 1; } } else if (request->state == RUN_FETCH_LOOSE) { - fchmod(request->local_fileno, 0444); close(request->local_fileno); request->local_fileno = -1; if (request->curl_result != CURLE_OK && |