summaryrefslogtreecommitdiff
path: root/help.c
diff options
context:
space:
mode:
authorRamsay Jones <ramsay@ramsay1.demon.co.uk>2013-06-22 20:42:47 +0100
committerJunio C Hamano <gitster@pobox.com>2013-07-18 10:44:17 -0700
commitf66450ae94f28a565226c3e443df5433722c5672 (patch)
tree7e2a224187ca1f1a5758e37ac7d6e5b5a0207372 /help.c
parent001b0976afe6f41bff46aa3eaad0285b641a50ea (diff)
downloadgit-f66450ae94f28a565226c3e443df5433722c5672.tar.gz
cygwin: Remove the Win32 l/stat() implementationrj/cygwin-clarify-use-of-cheating-lstat
Commit adbc0b6b ("cygwin: Use native Win32 API for stat", 30-09-2008) added a Win32 specific implementation of the stat functions. In order to handle absolute paths, cygwin mount points and symbolic links, this implementation may fall back on the standard cygwin l/stat() functions. Also, the choice of cygwin or Win32 functions is made lazily (by the first call(s) to l/stat) based on the state of some config variables. Unfortunately, this "schizophrenic stat" implementation has been the source of many problems ever since. For example, see commits 7faee6b8, 79748439, 452993c2, 085479e7, b8a97333, 924aaf3e, 05bab3ea and 0117c2f0. In order to avoid further problems, such as the issue raised by the new reference handling API, remove the Win32 l/stat() implementation. Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'help.c')
-rw-r--r--help.c5
1 files changed, 1 insertions, 4 deletions
diff --git a/help.c b/help.c
index 08c54ef1c1..f068925bb7 100644
--- a/help.c
+++ b/help.c
@@ -107,10 +107,7 @@ static int is_executable(const char *name)
!S_ISREG(st.st_mode))
return 0;
-#if defined(GIT_WINDOWS_NATIVE) || defined(__CYGWIN__)
-#if defined(__CYGWIN__)
-if ((st.st_mode & S_IXUSR) == 0)
-#endif
+#if defined(GIT_WINDOWS_NATIVE)
{ /* cannot trust the executable bit, peek into the file instead */
char buf[3] = { 0 };
int n;