diff options
author | Jeff King <peff@peff.net> | 2015-09-24 17:06:51 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2015-09-25 10:18:18 -0700 |
commit | 19bdd3e7e160a0b000c15d8bf6d33f4149e3f911 (patch) | |
tree | 4afb39180ae8a79401ffd02774d6b9523c156168 /grep.c | |
parent | 48bdf86995423736f36557d744841b08c8bf4e14 (diff) | |
download | git-19bdd3e7e160a0b000c15d8bf6d33f4149e3f911.tar.gz |
grep: use xsnprintf to format failure message
This looks at first glance like the sprintf can overflow our
buffer, but it's actually fine; the p->origin string is
something constant and small, like "command line" or "-e
option".
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'grep.c')
-rw-r--r-- | grep.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -306,9 +306,9 @@ static NORETURN void compile_regexp_failed(const struct grep_pat *p, char where[1024]; if (p->no) - sprintf(where, "In '%s' at %d, ", p->origin, p->no); + xsnprintf(where, sizeof(where), "In '%s' at %d, ", p->origin, p->no); else if (p->origin) - sprintf(where, "%s, ", p->origin); + xsnprintf(where, sizeof(where), "%s, ", p->origin); else where[0] = 0; |