summaryrefslogtreecommitdiff
path: root/graph.c
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2016-08-31 16:27:19 -0700
committerJunio C Hamano <gitster@pobox.com>2016-08-31 18:07:08 -0700
commitcd48dadb8d840637f0f55b1ad0d8f50d892c767d (patch)
tree6849336923f9a8d3e5ecedc8c9b97ff4a0071579 /graph.c
parent8576fde6cb4013a41d162e33f7a0046a5ea6801e (diff)
downloadgit-cd48dadb8d840637f0f55b1ad0d8f50d892c767d.tar.gz
diff.c: remove output_prefix_length field
"diff/log --stat" has a logic that determines the display columns available for the diffstat part of the output and apportions it for pathnames and diffstat graph automatically. 5e71a84a (Add output_prefix_length to diff_options, 2012-04-16) added the output_prefix_length field to diff_options structure to allow this logic to subtract the display columns used for the history graph part from the total "terminal width"; this matters when the "git log --graph -p" option is in use. The field must be set to the number of display columns needed to show the output from the output_prefix() callback, which is error prone. As there is only one user of the field, and the user has the actual value of the prefix string, let's get rid of the field and have the user count the display width itself. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'graph.c')
-rw-r--r--graph.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/graph.c b/graph.c
index dd1720148d..a468038405 100644
--- a/graph.c
+++ b/graph.c
@@ -197,7 +197,6 @@ static struct strbuf *diff_output_prefix_callback(struct diff_options *opt, void
assert(opt);
assert(graph);
- opt->output_prefix_length = graph->width;
strbuf_reset(&msgbuf);
graph_padding_line(graph, &msgbuf);
return &msgbuf;
@@ -245,7 +244,6 @@ struct git_graph *graph_init(struct rev_info *opt)
*/
opt->diffopt.output_prefix = diff_output_prefix_callback;
opt->diffopt.output_prefix_data = graph;
- opt->diffopt.output_prefix_length = 0;
return graph;
}