diff options
author | Jakub Narebski <jnareb@gmail.com> | 2006-11-18 23:35:38 +0100 |
---|---|---|
committer | Junio C Hamano <junkio@cox.net> | 2006-11-21 14:35:40 -0800 |
commit | 04408c3578300ac7cc1b1530bbaec54de299b200 (patch) | |
tree | ee3a83071002638b23ac16b874d1cfa1f5b0620d /gitweb | |
parent | 69945602f95710f16ab4a5f8edfee38dc65555fa (diff) | |
download | git-04408c3578300ac7cc1b1530bbaec54de299b200.tar.gz |
gitweb: Protect against possible warning in git_commitdiff
We may read an undef from <$fd> and unconditionally chomping it
would result in a warning.
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'gitweb')
-rwxr-xr-x | gitweb/gitweb.perl | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 758759576c..b2482febfc 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -3731,7 +3731,8 @@ sub git_commitdiff { $hash_parent, $hash, "--" or die_error(undef, "Open git-diff-tree failed"); - while (chomp(my $line = <$fd>)) { + while (my $line = <$fd>) { + chomp $line; # empty line ends raw part of diff-tree output last unless $line; push @difftree, $line; |