diff options
| author | Jonathan Nieder <jrnieder@gmail.com> | 2017-05-31 17:17:43 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-06-01 11:23:35 +0900 |
| commit | bfbfc9a953d8e26b029110c05581b22f9f0d77e9 (patch) | |
| tree | ad353ceee5872dbb2ea6980cc7d59d61b5b7a402 /git-send-email.perl | |
| parent | 0ead000c3aca13a10ae51a3c74c866981e0d33b8 (diff) | |
| download | git-bfbfc9a953d8e26b029110c05581b22f9f0d77e9.tar.gz | |
send-email: Net::SMTP::starttls was introduced in v2.34dk/send-email-avoid-net-smtp-ssl-when-able
We cannot rely on the starttls method being present in Net::SMTP until
c274b798e6881a941d941808c6d89966975cb8c8 (Merge branch 'ipv6_ssl' of
https://github.com/noxxi/perl-libnet into noxxi-ipv6_ssl, 2014-06-02),
which set the module version to 2.34.
This version was first shipped as part of perl in v5.21.5~169 (Update
libnet to CPAN version 3.01, 2014-10-10).
Noticed on an Ubuntu system with perl 5.18.2-2ubuntu1.1, which
provides Net::SMTP version 2.31. The error message is
Can't locate object method "starttls" via package "Net::SMTP" at /usr/lib/git-core/git-send-email line 1410.
Reported-by: Brandon Williams <bmwill@google.com>
Reported-and-tested-by: Eric Biggers <ebiggers3@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-send-email.perl')
| -rwxr-xr-x | git-send-email.perl | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/git-send-email.perl b/git-send-email.perl index 0d90439d9a..d326238c0a 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -1354,7 +1354,7 @@ EOF } require Net::SMTP; - my $use_net_smtp_ssl = version->parse($Net::SMTP::VERSION) < version->parse("1.28"); + my $use_net_smtp_ssl = version->parse($Net::SMTP::VERSION) < version->parse("2.34"); $smtp_domain ||= maildomain(); if ($smtp_encryption eq 'ssl') { |