diff options
| author | Elia Pinto <gitter.spiros@gmail.com> | 2014-04-23 06:43:58 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-04-23 15:17:02 -0700 |
| commit | eadf619cd434135bdfa598566376b3e3dbf9f2b5 (patch) | |
| tree | 2c6f2486925cb97acd9e7b5160e59e294635a957 /git-pull.sh | |
| parent | faf58f4ee6a5599c3b8790b770d6e1736174b7a3 (diff) | |
| download | git-eadf619cd434135bdfa598566376b3e3dbf9f2b5.tar.gz | |
git-pull.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-pull.sh')
| -rwxr-xr-x | git-pull.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/git-pull.sh b/git-pull.sh index 6cd8ebc534..cfc589dc15 100755 --- a/git-pull.sh +++ b/git-pull.sh @@ -108,7 +108,7 @@ do -s|--s|--st|--str|--stra|--strat|--strate|--strateg|--strategy) case "$#,$1" in *,*=*) - strategy=`expr "z$1" : 'z-[^=]*=\(.*\)'` ;; + strategy=$(expr "z$1" : 'z-[^=]*=\(.*\)') ;; 1,*) usage ;; *) |