diff options
author | Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> | 2011-02-16 05:47:45 -0500 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2011-02-16 13:21:09 -0800 |
commit | 2f59c947044d535e078941711e562d825eb055e3 (patch) | |
tree | cc7502f44589d802417cdc6c293a593fe9e5ab7f /git-mergetool.sh | |
parent | ac49f5ca84d82e5b10bc1eb022dfdd9b0e8f7749 (diff) | |
download | git-2f59c947044d535e078941711e562d825eb055e3.tar.gz |
mergetool: don't skip modify/remove conflicts
Since bb0a484 (mergetool: Skip autoresolved paths, 2010-08-17),
mergetool uses different ways of figuring out the list of files with
merge conflicts depending on whether rerere is active. If rerere is
active, mergetool will use 'git rerere status' to list the files with
remaining conflicts. However, the output from that command does not
list conflicts of types that rerere does not handle, such as
modify/remove conflicts.
Another problem with solely relying on the output from 'git rerere
status' is that, for new conflicts that are not yet known to rerere,
the output from the command will list the files even after adding them
to the index. This means that if the conflicts in some files have been
resolved and 'git mergetool' is run again, it will ask the user
something like the following for each of those files.
file1: file does not need merging
Continue merging other unresolved paths (y/n) ?
Solve both of these problems by replacing the call to 'git rerere
status' with a call to the new 'git rerere remaining' that was
introduced in the previous commit.
Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-mergetool.sh')
-rwxr-xr-x | git-mergetool.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/git-mergetool.sh b/git-mergetool.sh index 2f8dc441c6..bacbda2bb7 100755 --- a/git-mergetool.sh +++ b/git-mergetool.sh @@ -269,7 +269,7 @@ rerere=false files_to_merge() { if test "$rerere" = true then - git rerere status + git rerere remaining else git ls-files -u | sed -e 's/^[^ ]* //' | sort -u fi |