diff options
| author | Elia Pinto <gitter.spiros@gmail.com> | 2017-01-31 13:45:35 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-01-31 10:09:00 -0800 |
| commit | 4a5281917b2b84affa9942c991419115088aec0e (patch) | |
| tree | 201277e7d106ba5e8283fb81715f46924f72d997 /git-lost-found.sh | |
| parent | 8d7aa4ba6a00b3ff69261e88b4842c0df5662125 (diff) | |
| download | git-ep/commit-static-buf-cleanup.tar.gz | |
builtin/commit.c: switch to strbuf, instead of snprintf()ep/commit-static-buf-cleanup
Switch to dynamic allocation with strbuf, so we can avoid dealing
with magic numbers in the code and reduce the cognitive burden from
the programmers. The original code is correct, but programmers no
longer have to count bytes needed for static allocation to know that.
As a side effect of this change, we also reduce the snprintf()
calls, that may silently truncate results if the programmer is not
careful.
Helped-by: René Scharfe <l.s.r@web.de>
Helped-by: Junio C Hamano <gitster@pobox.com>
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-lost-found.sh')
0 files changed, 0 insertions, 0 deletions