diff options
| author | David Aguilar <davvid@gmail.com> | 2009-04-11 20:41:56 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2009-04-12 15:19:12 -0700 |
| commit | 47d65924a69576bd9f3254f7055de6b37a359596 (patch) | |
| tree | 8476f9097193153c708498c78cc7e9bc3db6946e /git-difftool--helper.sh | |
| parent | 70af4e9bef988a98061237c78cbd0a71d8de48bb (diff) | |
| download | git-47d65924a69576bd9f3254f7055de6b37a359596.tar.gz | |
mergetool--lib: simplify API usage by removing more global variables
The mergetool--lib scriplet was tricky to use because it relied upon
the existance of several global shell variables. This removes more
global variables so that things are simpler for callers.
A side effect is that some variables are recomputed each time
run_merge_tool() is called, but the overhead for recomputing
them is justified by the simpler implementation.
Signed-off-by: David Aguilar <davvid@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-difftool--helper.sh')
| -rwxr-xr-x | git-difftool--helper.sh | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/git-difftool--helper.sh b/git-difftool--helper.sh index b4500368c3..57e8e3256d 100755 --- a/git-difftool--helper.sh +++ b/git-difftool--helper.sh @@ -47,9 +47,9 @@ launch_merge_tool () { test -n "$GIT_MERGE_TOOL" && merge_tool="$GIT_MERGE_TOOL" test -n "$GIT_DIFF_TOOL" && merge_tool="$GIT_DIFF_TOOL" -merge_tool=$(get_merge_tool "$merge_tool") || exit -merge_tool_cmd="$(get_merge_tool_cmd "$merge_tool")" -merge_tool_path="$(get_merge_tool_path "$merge_tool")" || exit +if test -z "$merge_tool"; then + merge_tool="$(get_merge_tool)" || exit +fi # Launch the merge tool on each path provided by 'git diff' while test $# -gt 6 |