diff options
| author | Jeff King <peff@peff.net> | 2013-07-09 20:19:12 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2013-07-09 22:23:09 -0700 |
| commit | eccb614924c9067eeceffa503e4da3683f1c8b6b (patch) | |
| tree | 153f2b480f11456aa7678052a02fd975a89218c7 /exec_cmd.h | |
| parent | 4621085b7eb2f4cffe16d508988ff9b4a874b4ef (diff) | |
| download | git-eccb614924c9067eeceffa503e4da3683f1c8b6b.tar.gz | |
use "sentinel" function attribute for variadic lists
This attribute can help gcc notice when callers forget to
add a NULL sentinel to the end of the function. This is our
first use of the sentinel attribute, but we shouldn't need
to #ifdef for other compilers, as __attribute__ is already a
no-op on non-gcc-compatible compilers.
Suggested-by: Bert Wesarg <bert.wesarg@googlemail.com>
More-Spots-Found-By: Matt Kraai <kraai@ftbfs.org>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'exec_cmd.h')
| -rw-r--r-- | exec_cmd.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/exec_cmd.h b/exec_cmd.h index e2b546b615..307b55cbad 100644 --- a/exec_cmd.h +++ b/exec_cmd.h @@ -7,6 +7,7 @@ extern const char *git_exec_path(void); extern void setup_path(void); extern const char **prepare_git_cmd(const char **argv); extern int execv_git_cmd(const char **argv); /* NULL terminated */ +__attribute__((sentinel)) extern int execl_git_cmd(const char *cmd, ...); extern const char *system_path(const char *path); |