summaryrefslogtreecommitdiff
path: root/editor.c
diff options
context:
space:
mode:
authorRené Scharfe <l.s.r@web.de>2014-08-19 21:09:35 +0200
committerJunio C Hamano <gitster@pobox.com>2014-08-20 09:53:37 -0700
commitd3180279322c7450a47decf8833de47f444ca93f (patch)
tree6b15045aef08b51a0831ee75bb67fd0beddc0d0c /editor.c
parent6c4ab27f2378ce67940b4496365043119d7ffff2 (diff)
downloadgit-d3180279322c7450a47decf8833de47f444ca93f.tar.gz
run-command: introduce CHILD_PROCESS_INIT
Most struct child_process variables are cleared using memset first after declaration. Provide a macro, CHILD_PROCESS_INIT, that can be used to initialize them statically instead. That's shorter, doesn't require a function call and is slightly more readable (especially given that we already have STRBUF_INIT, ARGV_ARRAY_INIT etc.). Helped-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'editor.c')
-rw-r--r--editor.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/editor.c b/editor.c
index 0abbd8dc3a..01c644cddb 100644
--- a/editor.c
+++ b/editor.c
@@ -38,10 +38,9 @@ int launch_editor(const char *path, struct strbuf *buffer, const char *const *en
if (strcmp(editor, ":")) {
const char *args[] = { editor, real_path(path), NULL };
- struct child_process p;
+ struct child_process p = CHILD_PROCESS_INIT;
int ret, sig;
- memset(&p, 0, sizeof(p));
p.argv = args;
p.env = env;
p.use_shell = 1;