summaryrefslogtreecommitdiff
path: root/config.mak.uname
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2016-11-30 23:52:43 -0500
committerJunio C Hamano <gitster@pobox.com>2016-12-06 13:27:11 -0800
commit1f7c9261320576fcaaa5b4e50ad73336b17183e8 (patch)
tree358c866f7964837cd50c059184a9735d08553a78 /config.mak.uname
parent8d7a455ed52e2a96debc080dfc011b6bb00db5d2 (diff)
downloadgit-1f7c9261320576fcaaa5b4e50ad73336b17183e8.tar.gz
xdiff: drop XDL_FAST_HASHjk/xdiff-drop-xdl-fast-hash
The xdiff code hashes every line of both sides of a diff, and then compares those hashes to find duplicates. The overall performance depends both on how fast we can compute the hashes, but also on how many hash collisions we see. The idea of XDL_FAST_HASH is to speed up the hash computation. But the generated hashes have worse collision behavior. This means that in some cases it speeds diffs up (running "git log -p" on git.git improves by ~8% with it), but in others it can slow things down. One pathological case saw over a 100x slowdown[1]. There may be a better hash function that covers both properties, but in the meantime we are better off with the original hash. It's slightly slower in the common case, but it has fewer surprising pathological cases. [1] http://public-inbox.org/git/20141222041944.GA441@peff.net/ Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'config.mak.uname')
-rw-r--r--config.mak.uname3
1 files changed, 0 insertions, 3 deletions
diff --git a/config.mak.uname b/config.mak.uname
index b232908f8c..447f36ac2e 100644
--- a/config.mak.uname
+++ b/config.mak.uname
@@ -17,9 +17,6 @@ endif
# because maintaining the nesting to match is a pain. If
# we had "elif" things would have been much nicer...
-ifeq ($(uname_M),x86_64)
- XDL_FAST_HASH = YesPlease
-endif
ifeq ($(uname_S),OSF1)
# Need this for u_short definitions et al
BASIC_CFLAGS += -D_OSF_SOURCE