diff options
| author | Jim Meyering <jim@meyering.net> | 2007-12-08 16:48:05 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2007-12-08 14:24:13 -0800 |
| commit | 6281f394674bf2db861967da6c2215cfc3fc78af (patch) | |
| tree | fdfab53d81a1e017d1d12c45bb1e88eee3f606fe /config.c | |
| parent | 8e7425da782cbdff4531d84e0ef4ec7bd3ae23d7 (diff) | |
| download | git-6281f394674bf2db861967da6c2215cfc3fc78af.tar.gz | |
config.c:store_write_pair(): don't read the byte before a malloc'd buffer.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'config.c')
| -rw-r--r-- | config.c | 10 |
1 files changed, 8 insertions, 2 deletions
@@ -630,13 +630,19 @@ static int store_write_pair(int fd, const char* key, const char* value) int length = strlen(key+store.baselen+1); int quote = 0; - /* Check to see if the value needs to be quoted. */ + /* + * Check to see if the value needs to be surrounded with a dq pair. + * Note that problematic characters are always backslash-quoted; this + * check is about not losing leading or trailing SP and strings that + * follow beginning-of-comment characters (i.e. ';' and '#') by the + * configuration parser. + */ if (value[0] == ' ') quote = 1; for (i = 0; value[i]; i++) if (value[i] == ';' || value[i] == '#') quote = 1; - if (value[i-1] == ' ') + if (i && value[i-1] == ' ') quote = 1; if (write_in_full(fd, "\t", 1) != 1 || |