summaryrefslogtreecommitdiff
path: root/compat/gmtime.c
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2014-04-01 17:28:42 -0400
committerJunio C Hamano <gitster@pobox.com>2014-04-01 14:39:04 -0700
commit6654754779d2a90af91a9c6b93d7e4e7ee16cfab (patch)
tree1b6a7851e5e1dfd88ac4705de569343dfe0f0931 /compat/gmtime.c
parent3f419d45ef0dfc33dc301d9ae4737043c091291a (diff)
downloadgit-6654754779d2a90af91a9c6b93d7e4e7ee16cfab.tar.gz
date: recognize bogus FreeBSD gmtime output
Most gmtime implementations return a NULL value when they encounter an error (and this behavior is specified by ANSI C and POSIX). FreeBSD's implementation, however, will simply leave the "struct tm" untouched. Let's also recognize this and convert it to a NULL (with this patch, t4212 should pass on FreeBSD). Reported-by: René Scharfe <l.s.r@web.de> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'compat/gmtime.c')
-rw-r--r--compat/gmtime.c29
1 files changed, 29 insertions, 0 deletions
diff --git a/compat/gmtime.c b/compat/gmtime.c
new file mode 100644
index 0000000000..e8362dd2b9
--- /dev/null
+++ b/compat/gmtime.c
@@ -0,0 +1,29 @@
+#include "../git-compat-util.h"
+#undef gmtime
+#undef gmtime_r
+
+struct tm *git_gmtime(const time_t *timep)
+{
+ static struct tm result;
+ return git_gmtime_r(timep, &result);
+}
+
+struct tm *git_gmtime_r(const time_t *timep, struct tm *result)
+{
+ struct tm *ret;
+
+ memset(result, 0, sizeof(*result));
+ ret = gmtime_r(timep, result);
+
+ /*
+ * Rather than NULL, FreeBSD gmtime simply leaves the "struct tm"
+ * untouched when it encounters overflow. Since "mday" cannot otherwise
+ * be zero, we can test this very quickly.
+ */
+ if (ret && !ret->tm_mday) {
+ ret = NULL;
+ errno = EOVERFLOW;
+ }
+
+ return ret;
+}