summaryrefslogtreecommitdiff
path: root/commit.c
diff options
context:
space:
mode:
authorRené Scharfe <l.s.r@web.de>2016-08-13 14:21:27 +0200
committerJunio C Hamano <gitster@pobox.com>2016-08-13 19:48:07 -0700
commit5447a76aad4074c31e7c8a6299cc586435f385e9 (patch)
treeb20f9c8c067dcf65a0a47ff702efe8fe2fce05aa /commit.c
parenta25716535ba7ba85322a1e9f20168f31c61dae81 (diff)
downloadgit-5447a76aad4074c31e7c8a6299cc586435f385e9.tar.gz
commit: use FLEX_ARRAY in struct merge_remote_descrs/pull-signed-tag
Convert the name member of struct merge_remote_desc to a FLEX_ARRAY and use FLEX_ALLOC_STR to build the struct. This halves the number of memory allocations, saves the storage for a pointer and avoids an indirection when reading the name. Suggested-by: Jeff King <peff@peff.net> Signed-off-by: Rene Scharfe <l.s.r@web.de> Reviewed-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'commit.c')
-rw-r--r--commit.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/commit.c b/commit.c
index fc3d6fb2c3..5f616b7201 100644
--- a/commit.c
+++ b/commit.c
@@ -1580,9 +1580,8 @@ void set_merge_remote_desc(struct commit *commit,
const char *name, struct object *obj)
{
struct merge_remote_desc *desc;
- desc = xmalloc(sizeof(*desc));
+ FLEX_ALLOC_STR(desc, name, name);
desc->obj = obj;
- desc->name = xstrdup(name);
commit->util = desc;
}