diff options
author | Jeff King <peff@peff.net> | 2014-08-27 03:56:31 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-08-27 10:30:42 -0700 |
commit | 6876618ceaafddba625ed823679d99de0e79d111 (patch) | |
tree | b88b9e758dc287b1bef3ae0fc6ea61a6546314f9 /commit.c | |
parent | fe6eb7f2c506190c817407accf27834005a57f2b (diff) | |
download | git-6876618ceaafddba625ed823679d99de0e79d111.tar.gz |
record_author_date(): fix memory leak on malformed commit
If we hit the end-of-header without finding an "author"
line, we just return from the function. We should jump to
the fail_exit path to clean up the buffer that we may have
allocated.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'commit.c')
-rw-r--r-- | commit.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -594,7 +594,7 @@ static void record_author_date(struct author_date_slab *author_date, line_end = strchrnul(buf, '\n'); if (!skip_prefix(buf, "author ", &ident_line)) { if (!line_end[0] || line_end[1] == '\n') - return; /* end of header */ + goto fail_exit; /* end of header */ continue; } if (split_ident_line(&ident, |