summaryrefslogtreecommitdiff
path: root/builtin
diff options
context:
space:
mode:
authorJonathan Nieder <jrnieder@gmail.com>2010-08-11 03:36:07 -0500
committerJunio C Hamano <gitster@pobox.com>2010-08-15 19:12:00 -0700
commit130ab8ab9c64b59b367c08a041200b6b75758b91 (patch)
tree697b43173841964ecd428f04c1f90c04d404a67b /builtin
parent6bc83cdd0b9c7eab365e10d46d1e2acdb769728a (diff)
downloadgit-130ab8ab9c64b59b367c08a041200b6b75758b91.tar.gz
Eliminate “Finished cherry-pick/revert” message
When cherry-pick was written (v0.99.6~63, 2005-08-27), “git commit” was quiet, and the output from cherry-pick provided useful information about the progress of a rebase. Now next to the output from “git commit”, the cherry-pick notification is so much noise (except for the name of the picked commit). $ git cherry-pick ..topic Finished cherry-pick of 499088b. [detached HEAD 17e1ff2] Move glob module to libdpkg Author: Guillem Jover <guillem@debian.org> 8 files changed, 12 insertions(+), 9 deletions(-) rename {src => lib/dpkg}/glob.c (98%) rename {src => lib/dpkg}/glob.h (93%) Finished cherry-pick of ae947e1. [detached HEAD 058caa3] libdpkg: Add missing symbols to Versions script Author: Guillem Jover <guillem@debian.org> 1 files changed, 2 insertions(+), 0 deletions(-) $ The noise is especially troublesome when sifting through the output of a rebase or multiple cherry-pick that eventually failed. With the commit subject, it is already not hard to figure out where the commit came from. So drop the “Finished” message. Cc: Christian Couder <chriscool@tuxfamily.org> Cc: Thomas Rast <trast@student.ethz.ch> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
-rw-r--r--builtin/revert.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/builtin/revert.c b/builtin/revert.c
index e261fb2391..c3d64af02d 100644
--- a/builtin/revert.c
+++ b/builtin/revert.c
@@ -521,8 +521,6 @@ static int do_pick_commit(void)
} else {
if (!no_commit)
res = run_git_commit(defmsg);
- if (!res)
- fprintf(stderr, "Finished %s.\n", mebuf.buf);
}
strbuf_release(&mebuf);