diff options
author | Junio C Hamano <junkio@cox.net> | 2007-04-25 23:31:45 -0700 |
---|---|---|
committer | Junio C Hamano <junkio@cox.net> | 2007-04-25 23:31:45 -0700 |
commit | 6169a89c4fd29cf9c747bab7bd310877328bc7e2 (patch) | |
tree | 299d1cd315b66e377261901698bc128752466fc8 /builtin-write-tree.c | |
parent | a7b02ccf9a682fa0c2b28df6ca20f9199cdca4de (diff) | |
parent | 8abe88a29c0789276c6d028b76b1190630b101c6 (diff) | |
download | git-6169a89c4fd29cf9c747bab7bd310877328bc7e2.tar.gz |
Merge branch 'maint'
* maint:
Start preparing for 1.5.1.3
Sanitize @to recipients.
git-svn: Ignore usernames in URLs in find_by_url
Document --dry-run and envelope-sender for git-send-email.
Allow users to optionally specify their envelope sender.
Ensure clean addresses are always used with Net::SMTP
Validate @recipients before using it for sendmail and Net::SMTP.
Perform correct quoting of recipient names.
Change the scope of the $cc variable as it is not needed outside of send_message.
Debugging cleanup improvements
Prefix Dry- to the message status to denote dry-runs.
Document --dry-run parameter to send-email.
git-svn: Don't rely on $_ after making a function call
Fix handle leak in write_tree
Actually handle some-low memory conditions
Conflicts:
RelNotes
git-send-email.perl
Diffstat (limited to 'builtin-write-tree.c')
-rw-r--r-- | builtin-write-tree.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/builtin-write-tree.c b/builtin-write-tree.c index c88bbd1b9b..391de53972 100644 --- a/builtin-write-tree.c +++ b/builtin-write-tree.c @@ -36,8 +36,10 @@ int write_tree(unsigned char *sha1, int missing_ok, const char *prefix) die("git-write-tree: error building trees"); if (0 <= newfd) { if (!write_cache(newfd, active_cache, active_nr) - && !close(newfd)) + && !close(newfd)) { commit_lock_file(lock_file); + newfd = -1; + } } /* Not being able to write is fine -- we are only interested * in updating the cache-tree part, and if the next caller @@ -55,6 +57,8 @@ int write_tree(unsigned char *sha1, int missing_ok, const char *prefix) else hashcpy(sha1, active_cache_tree->sha1); + if (0 <= newfd) + close(newfd); rollback_lock_file(lock_file); return 0; |