diff options
| author | Shawn Pearce <spearce@spearce.org> | 2006-09-02 00:16:31 -0400 |
|---|---|---|
| committer | Junio C Hamano <junkio@cox.net> | 2006-09-02 03:24:37 -0700 |
| commit | 9befac470b4cfad529032dbcffcb71242ec71f91 (patch) | |
| tree | f3715172da747456dd63c6d80c3f1e0a7d6f2d56 /builtin-rev-list.c | |
| parent | ad1ed5ee896ba5d7f89bc04c7441b1532efb9853 (diff) | |
| download | git-9befac470b4cfad529032dbcffcb71242ec71f91.tar.gz | |
Replace uses of strdup with xstrdup.
Like xmalloc and xrealloc xstrdup dies with a useful message if
the native strdup() implementation returns NULL rather than a
valid pointer.
I just tried to use xstrdup in new code and found it to be missing.
However I expected it to be present as xmalloc and xrealloc are
already commonly used throughout the code.
[jc: removed the part that deals with last_XXX, which I am
finding more and more dubious these days.]
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'builtin-rev-list.c')
| -rw-r--r-- | builtin-rev-list.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/builtin-rev-list.c b/builtin-rev-list.c index 402af8e1b5..8437454fbe 100644 --- a/builtin-rev-list.c +++ b/builtin-rev-list.c @@ -109,7 +109,7 @@ static void process_blob(struct blob *blob, if (obj->flags & (UNINTERESTING | SEEN)) return; obj->flags |= SEEN; - name = strdup(name); + name = xstrdup(name); add_object(obj, p, path, name); } @@ -130,7 +130,7 @@ static void process_tree(struct tree *tree, if (parse_tree(tree) < 0) die("bad tree object %s", sha1_to_hex(obj->sha1)); obj->flags |= SEEN; - name = strdup(name); + name = xstrdup(name); add_object(obj, p, path, name); me.up = path; me.elem = name; |