diff options
| author | Jeff King <peff@peff.net> | 2010-01-29 05:31:30 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2010-01-29 09:56:12 -0800 |
| commit | 7b48c170931f35c07c3ce78023519846073152a1 (patch) | |
| tree | 1f463ad3cdebbc0f45203921987085021a50be83 /builtin-push.c | |
| parent | dace5dd14166ebc2b55f46695d27dce0e64c6464 (diff) | |
| download | git-7b48c170931f35c07c3ce78023519846073152a1.tar.gz | |
fix off-by-one allocation error
Caught by valgrind in t5516. Reading the code shows we
malloc enough for our string, but not trailing NUL.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin-push.c')
| -rw-r--r-- | builtin-push.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin-push.c b/builtin-push.c index 5df66081a6..5633f0ade4 100644 --- a/builtin-push.c +++ b/builtin-push.c @@ -52,7 +52,7 @@ static void set_refspecs(const char **refs, int nr) } else if (deleterefs && !strchr(ref, ':')) { char *delref; int len = strlen(ref)+1; - delref = xmalloc(len); + delref = xmalloc(len+1); strcpy(delref, ":"); strcat(delref, ref); ref = delref; |