diff options
| author | Thomas Rast <trast@student.ethz.ch> | 2009-10-19 17:48:08 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2009-10-19 22:28:20 -0700 |
| commit | dd2e794a214350711db46c4e08d9b19188a7d63a (patch) | |
| tree | d9566af4d6b5eac1ba0fa0f1e6e3a3b08d56b858 /builtin-checkout.c | |
| parent | 9ecb2a7f496413b9a6404e4a19f7edee029819b8 (diff) | |
| download | git-dd2e794a214350711db46c4e08d9b19188a7d63a.tar.gz | |
Refactor pretty_print_commit arguments into a struct
pretty_print_commit() has a bunch of rarely-used arguments, and
introducing more of them requires yet another update of all the call
sites. Refactor most of them into a struct to make future extensions
easier.
The ones that stay "plain" arguments were chosen on the grounds that
all callers put real arguments there, whereas some callers have 0/NULL
for all arguments that were factored into the struct.
We declare the struct 'const' to ensure none of the callers are bitten
by the changed (no longer call-by-value) semantics.
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin-checkout.c')
| -rw-r--r-- | builtin-checkout.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/builtin-checkout.c b/builtin-checkout.c index d050c3789f..075a49f1a0 100644 --- a/builtin-checkout.c +++ b/builtin-checkout.c @@ -302,8 +302,9 @@ static void show_local_changes(struct object *head) static void describe_detached_head(char *msg, struct commit *commit) { struct strbuf sb = STRBUF_INIT; + struct pretty_print_context ctx = {0}; parse_commit(commit); - pretty_print_commit(CMIT_FMT_ONELINE, commit, &sb, 0, NULL, NULL, 0, 0); + pretty_print_commit(CMIT_FMT_ONELINE, commit, &sb, &ctx); fprintf(stderr, "%s %s... %s\n", msg, find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV), sb.buf); strbuf_release(&sb); |