diff options
| author | Junio C Hamano <junkio@cox.net> | 2006-09-06 22:45:21 -0700 |
|---|---|---|
| committer | Junio C Hamano <junkio@cox.net> | 2006-09-07 02:44:40 -0700 |
| commit | 2b6eef943ff81df63a809857b7b400ee175eb29b (patch) | |
| tree | 8fab428249716f64abbe1a2286f6ab2b3ee3beb1 /builtin-apply.c | |
| parent | 7bbf88c52b202d543310123e1bad9a44b2d6f028 (diff) | |
| download | git-2b6eef943ff81df63a809857b7b400ee175eb29b.tar.gz | |
Make apply --binary a no-op.
Historically we did not allow binary patch applied without an
explicit permission from the user, and this flag was the way to
do so. This makes the flag a no-op by always allowing binary
patch application.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'builtin-apply.c')
| -rw-r--r-- | builtin-apply.c | 19 |
1 files changed, 5 insertions, 14 deletions
diff --git a/builtin-apply.c b/builtin-apply.c index 872c8005a2..6e0864ce27 100644 --- a/builtin-apply.c +++ b/builtin-apply.c @@ -28,7 +28,6 @@ static int prefix_length = -1; static int newfd = -1; static int p_value = 1; -static int allow_binary_replacement; static int check_index; static int write_index; static int cached; @@ -1228,14 +1227,12 @@ static int parse_chunk(char *buffer, unsigned long size, struct patch *patch) } } - /* Empty patch cannot be applied if: - * - it is a binary patch and we do not do binary_replace, or - * - text patch without metadata change + /* Empty patch cannot be applied if it is a text patch + * without metadata change. A binary patch appears + * empty to us here. */ if ((apply || check) && - (patch->is_binary - ? !allow_binary_replacement - : !metadata_changes(patch))) + (!patch->is_binary && !metadata_changes(patch))) die("patch with only garbage at line %d", linenr); } @@ -1676,11 +1673,6 @@ static int apply_binary(struct buffer_desc *desc, struct patch *patch) unsigned char hdr[50]; int hdrlen; - if (!allow_binary_replacement) - return error("cannot apply binary patch to '%s' " - "without --allow-binary-replacement", - name); - /* For safety, we require patch index line to contain * full 40-byte textual SHA1 for old and new, at least for now. */ @@ -2497,8 +2489,7 @@ int cmd_apply(int argc, const char **argv, const char *prefix) } if (!strcmp(arg, "--allow-binary-replacement") || !strcmp(arg, "--binary")) { - allow_binary_replacement = 1; - continue; + continue; /* now no-op */ } if (!strcmp(arg, "--numstat")) { apply = 0; |