diff options
| author | Ramsay Jones <ramsay@ramsay1.demon.co.uk> | 2011-04-07 19:49:33 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2011-04-22 10:04:27 -0700 |
| commit | c51477229ee4c7846d40a447860b5bf94aa1103d (patch) | |
| tree | 4bfce447467267ad409f75e33f5cb5d3ec6689d3 /attr.c | |
| parent | 0bcd9ae85d7e05e78a10a69a2ebe98dcde130937 (diff) | |
| download | git-c51477229ee4c7846d40a447860b5bf94aa1103d.tar.gz | |
sparse: Fix some "symbol not declared" warnings
In particular, sparse issues the "symbol 'a_symbol' was not declared.
Should it be static?" warnings for the following symbols:
attr.c:468:12: 'git_etc_gitattributes'
attr.c:476:5: 'git_attr_system'
vcs-svn/svndump.c:282:6: 'svndump_read'
vcs-svn/svndump.c:417:5: 'svndump_init'
vcs-svn/svndump.c:432:6: 'svndump_deinit'
vcs-svn/svndump.c:445:6: 'svndump_reset'
The symbols in attr.c only require file scope, so we add the static
modifier to their declaration.
The symbols in vcs-svn/svndump.c are external symbols, and they
already have extern declarations in the "svndump.h" header file,
so we simply include the header in svndump.c.
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'attr.c')
| -rw-r--r-- | attr.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -465,7 +465,7 @@ static void drop_attr_stack(void) } } -const char *git_etc_gitattributes(void) +static const char *git_etc_gitattributes(void) { static const char *system_wide; if (!system_wide) @@ -473,7 +473,7 @@ const char *git_etc_gitattributes(void) return system_wide; } -int git_attr_system(void) +static int git_attr_system(void) { return !git_env_bool("GIT_ATTR_NOSYSTEM", 0); } |