diff options
author | Saurav Sachidanand <sauravsachidanand@gmail.com> | 2016-03-01 22:32:59 +0530 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2016-03-01 10:20:22 -0800 |
commit | f870899864e077a54776af838c6476d5850cfaaf (patch) | |
tree | 0b9482b7e660103342c9464c47167a0b7c3709fa /attr.c | |
parent | a2558fb8e1e387b630312311e1d22c95663da5d0 (diff) | |
download | git-f870899864e077a54776af838c6476d5850cfaaf.tar.gz |
dir: store EXC_FLAG_* values in unsigned integersss/exc-flag-is-a-collection-of-bits
The values defined by the macro EXC_FLAG_* (1, 4, 8, 16) are stored
in fields of the structs "pattern" and "exclude", some functions
arguments and a local variable. None of these uses its most
significant bit in any special way and there is no good reason to
use a signed integer for them.
And while we're at it, document "flags" of "exclude" to explicitly
state the values it's supposed to take on.
Signed-off-by: Saurav Sachidanand <sauravsachidanand@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'attr.c')
-rw-r--r-- | attr.c | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -124,7 +124,7 @@ struct pattern { const char *pattern; int patternlen; int nowildcardlen; - int flags; /* EXC_FLAG_* */ + unsigned flags; /* EXC_FLAG_* */ }; /* |