diff options
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2010-07-28 14:12:59 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2010-07-28 13:51:12 -0700 |
| commit | 6a58696f5b446cef4874c45b1c953403707325b8 (patch) | |
| tree | 9bfebdaa12e9f9afb25f14a6831af40bcc29c5b7 /Documentation | |
| parent | 1e39d7deea6719074b5b1487d1634d4704da357b (diff) | |
| download | git-6a58696f5b446cef4874c45b1c953403707325b8.tar.gz | |
SubmittingPatches: Clarify the Signed-off-by rules
The wording of the Signed-off-by rules could be read as stating that
S-O-B should only be added when the submitter considered the patch
ready for inclusion in git.git.
We also want Signed-off-by to be used for e.g. RFC patches, in case
someone wants to dig an old patch out of the archive and improve
it. Change the wording to recommend a Signed-off-by for all submitted
patches.
The problem with the wording came up in the "[PATCH/RFC] Hacky version
of a glob() driven config include" thread[1]. Bert Wesarg suggested[2]
that it be removed to avoid confusion, which this change implements.
1. <1273180440-8641-1-git-send-email-avarab@gmail.com>
2. <AANLkTimziTKL13VKIOcaS1TX1F_xvTVjH8Q398Yx36Us@mail.gmail.com>
Suggested-by: Bert Wesarg <bert.wesarg@googlemail.com>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'Documentation')
| -rw-r--r-- | Documentation/SubmittingPatches | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index eb53e0636e..2e18f6b440 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -13,11 +13,9 @@ Checklist (and a short version for the impatient): not "changed" or "changes". - includes motivation for the change, and contrasts its implementation with previous behaviour - - if you want your work included in git.git, add a - "Signed-off-by: Your Name <you@example.com>" line to the - commit message (or just use the option "-s" when - committing) to confirm that you agree to the Developer's - Certificate of Origin + - add a "Signed-off-by: Your Name <you@example.com>" line to the + commit message (or just use the option "-s" when committing) + to confirm that you agree to the Developer's Certificate of Origin - make sure that you have tests for the bug you are fixing - make sure that the test suite passes after your commit |