diff options
| author | Jeff King <peff@peff.net> | 2011-02-12 00:18:51 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2011-02-14 10:55:03 -0800 |
| commit | 62b8102c60a716e66cfd2a33e596e9d5be134267 (patch) | |
| tree | d3def01dc545c9ba7d4bf6962f0c8ca139928572 | |
| parent | dab0d4108d7b45905a12ec6cea2cfc20ea8eabef (diff) | |
| download | git-62b8102c60a716e66cfd2a33e596e9d5be134267.tar.gz | |
string_list_append: always set util pointer to NULL
It is not immediately obvious that the util field may
contain random bytes after appending an item. Especially
since the string_list_insert* functions _do_ explicitly zero
the util pointer.
This does not appear to be a bug in any current git code, as
all callers either fill in the util field immediately or
never use it. However, it is worth it to be less surprising
to new users of the string-list API who may expect it to be
intialized to NULL.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | string-list.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/string-list.c b/string-list.c index 9b023a2584..51681189e8 100644 --- a/string-list.c +++ b/string-list.c @@ -153,6 +153,7 @@ struct string_list_item *string_list_append(struct string_list *list, const char ALLOC_GROW(list->items, list->nr + 1, list->alloc); list->items[list->nr].string = list->strdup_strings ? xstrdup(string) : (char *)string; + list->items[list->nr].util = NULL; return list->items + list->nr++; } |