diff options
| author | Elijah Newren <newren@gmail.com> | 2023-05-09 19:53:39 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2023-05-09 14:46:53 -0700 |
| commit | 317ac15b140f693c538963471c49063e9613058f (patch) | |
| tree | 88fe3f1ad3f25c9424382771c11981b0156077e1 | |
| parent | 1bf61baa2138a3608df427e9c9df6cd6c1a05884 (diff) | |
| download | git-317ac15b140f693c538963471c49063e9613058f.tar.gz | |
replay: add an important FIXME comment about gpg signing
We want to be able to handle signed commits in some way in the future,
but we are not ready to do it now. So for the time being let's just add
a FIXME comment to remind us about it.
These are different ways we could handle them:
- in case of a cli user and if there was an interactive mode, we could
perhaps ask if the user wants to sign again
- we could add an option to just fail if there are signed commits
Co-authored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | builtin/replay.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/replay.c b/builtin/replay.c index 9f6cca2972..a9d88ac6df 100644 --- a/builtin/replay.c +++ b/builtin/replay.c @@ -60,7 +60,7 @@ static struct commit *create_commit(struct tree *tree, struct object *obj; struct commit_list *parents = NULL; char *author; - char *sign_commit = NULL; + char *sign_commit = NULL; /* FIXME: cli users might want to sign again */ struct commit_extra_header *extra; struct strbuf msg = STRBUF_INIT; const char *out_enc = get_commit_output_encoding(); |