diff options
author | Jeff King <peff@peff.net> | 2014-06-10 17:40:46 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-06-13 12:08:17 -0700 |
commit | a97934d8205772ffd2a528a9e970af7dec725012 (patch) | |
tree | 3b05fc0118344324608d2ae16e0006639ccdf74b | |
parent | 152ff1ccebd822fd97f27d2a6c3fa2058f088fd8 (diff) | |
download | git-a97934d8205772ffd2a528a9e970af7dec725012.tar.gz |
use get_cached_commit_buffer where appropriate
Some call sites check commit->buffer to see whether we have
a cached buffer, and if so, do some work with it. In the
long run we may want to switch these code paths to make
their decision on a different boolean flag (because checking
the cache may get a little more expensive in the future).
But for now, we can easily support them by converting the
calls to use get_cached_commit_buffer.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r-- | builtin/rev-list.c | 2 | ||||
-rw-r--r-- | log-tree.c | 2 | ||||
-rw-r--r-- | object.c | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/builtin/rev-list.c b/builtin/rev-list.c index e012ebe502..3fcbf21c03 100644 --- a/builtin/rev-list.c +++ b/builtin/rev-list.c @@ -106,7 +106,7 @@ static void show_commit(struct commit *commit, void *data) else putchar('\n'); - if (revs->verbose_header && commit->buffer) { + if (revs->verbose_header && get_cached_commit_buffer(commit)) { struct strbuf buf = STRBUF_INIT; struct pretty_print_context ctx = {0}; ctx.abbrev = revs->abbrev; diff --git a/log-tree.c b/log-tree.c index cf2f86c866..e9ef8abd37 100644 --- a/log-tree.c +++ b/log-tree.c @@ -588,7 +588,7 @@ void show_log(struct rev_info *opt) show_mergetag(opt, commit); } - if (!commit->buffer) + if (!get_cached_commit_buffer(commit)) return; if (opt->show_notes) { @@ -197,7 +197,7 @@ struct object *parse_object_buffer(const unsigned char *sha1, enum object_type t if (commit) { if (parse_commit_buffer(commit, buffer, size)) return NULL; - if (!commit->buffer) { + if (!get_cached_commit_buffer(commit)) { set_commit_buffer(commit, buffer); *eaten_p = 1; } |