diff options
author | Junio C Hamano <gitster@pobox.com> | 2015-11-05 12:18:06 -0800 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2015-11-05 12:18:06 -0800 |
commit | 53be145209eeac5972d4ea4374d667fdf594f78f (patch) | |
tree | 8863ee39fd435345552a3bce214ee11b8f053509 | |
parent | 684fea37948d720cc69b3553b42353b4b42709dc (diff) | |
parent | f60c483d1d135a1f5f7c6067198a6207f1e59dc6 (diff) | |
download | git-53be145209eeac5972d4ea4374d667fdf594f78f.tar.gz |
Merge branch 'sa/send-email-smtp-batch-data-limit' into maint
When "git send-email" wanted to talk over Net::SMTP::SSL,
Net::Cmd::datasend() did not like to be fed too many bytes at the
same time and failed to send messages. Send the payload one line
at a time to work around the problem.
* sa/send-email-smtp-batch-data-limit:
git-send-email.perl: Fixed sending of many/huge changes/patches
-rwxr-xr-x | git-send-email.perl | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/git-send-email.perl b/git-send-email.perl index e3ff44b4d0..e907e0eacf 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -1365,7 +1365,11 @@ Message-Id: $message_id $smtp->mail( $raw_from ) or die $smtp->message; $smtp->to( @recipients ) or die $smtp->message; $smtp->data or die $smtp->message; - $smtp->datasend("$header\n$message") or die $smtp->message; + $smtp->datasend("$header\n") or die $smtp->message; + my @lines = split /^/, $message; + foreach my $line (@lines) { + $smtp->datasend("$line") or die $smtp->message; + } $smtp->dataend() or die $smtp->message; $smtp->code =~ /250|200/ or die "Failed to send $subject\n".$smtp->message; } |