diff options
| author | Jeff King <peff@peff.net> | 2011-02-25 23:08:25 -0600 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2011-02-26 01:06:50 -0800 |
| commit | ab8632ae36d2e5faf524309696725b60ec18e588 (patch) | |
| tree | 1ed044a4c4546d92e2e09565fb81d7fec7dcaad0 | |
| parent | 046613c5465e4fc0611f93a5ef31d3815fb50c22 (diff) | |
| download | git-ab8632ae36d2e5faf524309696725b60ec18e588.tar.gz | |
compat: provide a fallback va_copy definition
va_copy is C99. We have avoided using va_copy many times in the past,
which has led to a bunch of cut-and-paste. From everything I found
searching the web, implementations have historically either provided
va_copy or just let your code assume that simple assignment of worked.
So my guess is that this will be sufficient, though we won't really
know for sure until somebody reports a problem.
Signed-off-by: Jeff King <peff@peff.net>
Improved-by: Erik Faye-Lund <kusmabite@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | compat/msvc.h | 1 | ||||
| -rw-r--r-- | git-compat-util.h | 4 |
2 files changed, 4 insertions, 1 deletions
diff --git a/compat/msvc.h b/compat/msvc.h index 023aba0238..a33b01c032 100644 --- a/compat/msvc.h +++ b/compat/msvc.h @@ -9,7 +9,6 @@ #define inline __inline #define __inline__ __inline #define __attribute__(x) -#define va_copy(dst, src) ((dst) = (src)) #define strncasecmp _strnicmp #define ftruncate _chsize diff --git a/git-compat-util.h b/git-compat-util.h index 9c23622ed5..00d41e4f0e 100644 --- a/git-compat-util.h +++ b/git-compat-util.h @@ -535,6 +535,10 @@ void git_qsort(void *base, size_t nmemb, size_t size, #define fstat_is_reliable() 1 #endif +#ifndef va_copy +#define va_copy(dst,src) (dst) = (src) +#endif + /* * Preserves errno, prints a message, but gives no warning for ENOENT. * Always returns the return value of unlink(2). |