summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPierre Habouzit <madcoder@debian.org>2009-07-22 23:51:55 +0200
committerJunio C Hamano <gitster@pobox.com>2009-07-22 21:57:41 -0700
commit24deea5273709f3685f981c33468a0cead6cc147 (patch)
treebbbebe0faa6ed83a988ce0ac635b5f0599260e51
parent98cb6f30f708ef416572bf65bd26ac9f998ae0dc (diff)
downloadgit-24deea5273709f3685f981c33468a0cead6cc147.tar.gz
janitor: useless checks before free
Signed-off-by: Pierre Habouzit <madcoder@debian.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--pack-revindex.c3
-rw-r--r--walker.c2
2 files changed, 2 insertions, 3 deletions
diff --git a/pack-revindex.c b/pack-revindex.c
index 1de53c8934..77a0465be6 100644
--- a/pack-revindex.c
+++ b/pack-revindex.c
@@ -149,8 +149,7 @@ void discard_revindex(void)
if (pack_revindex_hashsz) {
int i;
for (i = 0; i < pack_revindex_hashsz; i++)
- if (pack_revindex[i].revindex)
- free(pack_revindex[i].revindex);
+ free(pack_revindex[i].revindex);
free(pack_revindex);
pack_revindex_hashsz = 0;
}
diff --git a/walker.c b/walker.c
index e57630e983..11d9052ed8 100644
--- a/walker.c
+++ b/walker.c
@@ -245,7 +245,7 @@ void walker_targets_free(int targets, char **target, const char **write_ref)
{
while (targets--) {
free(target[targets]);
- if (write_ref && write_ref[targets])
+ if (write_ref)
free((char *) write_ref[targets]);
}
}