diff options
| author | Jeff King <peff@peff.net> | 2013-12-28 04:33:40 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-01-02 14:43:12 -0800 |
| commit | 738a8beac42d5e2c6b882f997b7fc6577363c544 (patch) | |
| tree | d54967715836c6001f85259d09e3f4ace0a16978 | |
| parent | a63c12c9be28bf455816b1ece4a52b463ecf6241 (diff) | |
| download | git-jk/test-framework-updates.tar.gz | |
t0000: drop "known breakage" testjk/test-framework-updates
Having a simulated "known breakage" test means that the test
suite will always tell us there is a bug to be fixed, even
though it is only simulated.
The right way to test this is in a sub-test, that can also
check that we provide the correct exit status and output.
Fortunately, we already have such a test (added much later
by 5ebf89e).
We could arguably get rid of the simulated success test
immediately above, as well, as it is also redundant with the
tests added in 5ebf89e. However, it does not have the
annoying behavior of the "known breakage" test. It may also
be easier to debug if the test suite is truly broken, since
it is not a test-within-a-test, as the later tests are.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t0000-basic.sh | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh index e6c5b63839..a2bb63ce8e 100755 --- a/t/t0000-basic.sh +++ b/t/t0000-basic.sh @@ -41,9 +41,6 @@ test_expect_success '.git/objects should have 3 subdirectories' ' test_expect_success 'success is reported like this' ' : ' -test_expect_failure 'pretend we have a known breakage' ' - false -' run_sub_test_lib_test () { name="$1" descr="$2" # stdin is the body of the test code |