summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Couder <chriscool@tuxfamily.org>2009-02-27 07:31:22 +0100
committerJunio C Hamano <gitster@pobox.com>2009-02-27 14:30:34 -0800
commitcce074a2760940cb78232ce2201ab5590e274d4a (patch)
tree078a2a03548b4d7c781a61d6304fa96591134fc0
parent1b249ffe8dff12849e3e215b46b245daecfadba0 (diff)
downloadgit-cce074a2760940cb78232ce2201ab5590e274d4a.tar.gz
bisect: fix another instance of eval'ed string
When there is nothing to be skipped, the output from rev-list --bisect-vars was eval'ed without first being strung together with &&; this is probably not a problem as it is much less likely to be a bad input than the list handcrafted by the filter_skip function, but it still is a good discipline. Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rwxr-xr-xgit-bisect.sh8
1 files changed, 7 insertions, 1 deletions
diff --git a/git-bisect.sh b/git-bisect.sh
index f9a5c0bdf4..b95dbbbbb2 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -263,7 +263,13 @@ filter_skipped() {
_skip="$2"
if [ -z "$_skip" ]; then
- eval_rev_list "$_eval"
+ eval_rev_list "$_eval" | {
+ while read line
+ do
+ echo "$line &&"
+ done
+ echo ':'
+ }
return
fi