diff options
| author | Elia Pinto <gitter.spiros@gmail.com> | 2016-01-12 11:49:27 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-01-12 11:49:46 -0800 |
| commit | 57da04965d56c7d7da6a00c3fb6fc3981cf0ba9a (patch) | |
| tree | 2f0010ed754945adcb7d3aac71750ddd821fd93f | |
| parent | 1d9e86f80d2ede6829c57ef4b22e4dd8b162cc7e (diff) | |
| download | git-57da04965d56c7d7da6a00c3fb6fc3981cf0ba9a.tar.gz | |
t9119-git-svn-info.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t9119-git-svn-info.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t9119-git-svn-info.sh b/t/t9119-git-svn-info.sh index f16f3234a1..88241baee3 100755 --- a/t/t9119-git-svn-info.sh +++ b/t/t9119-git-svn-info.sh @@ -8,7 +8,7 @@ test_description='git svn info' # Tested with: svn, version 1.4.4 (r25188) # Tested with: svn, version 1.6.[12345689] -v=`svn_cmd --version | sed -n -e 's/^svn, version \(1\.[0-9]*\.[0-9]*\).*$/\1/p'` +v=$(svn_cmd --version | sed -n -e 's/^svn, version \(1\.[0-9]*\.[0-9]*\).*$/\1/p') case $v in 1.[456].*) ;; |