summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChris Webb <chris@arachsys.com>2010-03-27 15:00:19 +0000
committerJunio C Hamano <gitster@pobox.com>2010-03-28 09:24:25 -0700
commit10439d89ebe77a1fb8f05a8ad5d5f4071639bb3e (patch)
treee683eaee4f3189c2dccd384b3e98d8f45cacb7f7
parent5e4f61474202122f376b16181b760f390623bf4e (diff)
downloadgit-10439d89ebe77a1fb8f05a8ad5d5f4071639bb3e.tar.gz
imap-send: suppress warning about cleartext password with CRAM-MD5
If a CRAM-MD5 challenge-response is used to authenticate to the IMAP server, git imap-send shouldn't warn about the password being sent in the clear. Signed-off-by: Chris Webb <chris@arachsys.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--imap-send.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/imap-send.c b/imap-send.c
index aeb2985b83..7107923a39 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -1226,9 +1226,6 @@ static struct store *imap_open_store(struct imap_server_conf *srvc)
fprintf(stderr, "Skipping account %s@%s, server forbids LOGIN\n", srvc->user, srvc->host);
goto bail;
}
- if (!imap->buf.sock.ssl)
- imap_warn("*** IMAP Warning *** Password is being "
- "sent in the clear\n");
if (srvc->auth_method) {
struct imap_cmd_cb cb;
@@ -1253,6 +1250,9 @@ static struct store *imap_open_store(struct imap_server_conf *srvc)
goto bail;
}
} else {
+ if (!imap->buf.sock.ssl)
+ imap_warn("*** IMAP Warning *** Password is being "
+ "sent in the clear\n");
if (imap_exec(ctx, NULL, "LOGIN \"%s\" \"%s\"", srvc->user, srvc->pass) != RESP_OK) {
fprintf(stderr, "IMAP error: LOGIN failed\n");
goto bail;