summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaul Mackerras <paulus@samba.org>2008-03-07 21:19:18 +1100
committerPaul Mackerras <paulus@samba.org>2008-03-07 21:19:18 +1100
commitd76afb15ada0e9e29cae2d83cd35d9489a042b0c (patch)
treeb4144bc94259c44677a030fcac2b5d227690e66f
parentc9cfdc9601668841a5909facd43aed72e7a8dee5 (diff)
downloadgit-d76afb15ada0e9e29cae2d83cd35d9489a042b0c.tar.gz
gitk: Avoid a crash in selectline if commitinfo($id) isn't set
Occasionally I see a crash in selectline with commitinfo($id) not set. This makes sure it is set by calling getcommit $id if it isn't. Signed-off-by: Paul Mackerras <paulus@samba.org>
-rwxr-xr-xgitk5
1 files changed, 4 insertions, 1 deletions
diff --git a/gitk b/gitk
index f2ebc600e7..19325086bf 100755
--- a/gitk
+++ b/gitk
@@ -1218,7 +1218,7 @@ proc chewcommits {} {
if {$viewcomplete($curview)} {
global commitidx varctok
global numcommits startmsecs
- global mainheadid commitinfo nullid
+ global mainheadid nullid
if {[info exists pending_select]} {
set row [first_real_row]
@@ -5494,6 +5494,9 @@ proc selectline {l isnew} {
$ctext conf -state normal
clear_ctext
set linknum 0
+ if {![info exists commitinfo($id)]} {
+ getcommit $id
+ }
set info $commitinfo($id)
set date [formatdate [lindex $info 2]]
$ctext insert end "[mc "Author"]: [lindex $info 1] $date\n"