summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2014-08-19 13:02:19 -0700
committerJunio C Hamano <gitster@pobox.com>2014-09-15 13:23:20 -0700
commitc67072b90bdc56501483e0ba96d0d833e86362c3 (patch)
tree161ab8115d96d23e30941731abe59293511cc7be
parentb783aa71c096032c02a20f9a41c5f42ce7b914c4 (diff)
downloadgit-c67072b90bdc56501483e0ba96d0d833e86362c3.tar.gz
send-pack: clarify that cmds_sent is a boolean
We use it to make sure that the feature request is sent only once on the very first request packet (ignoring the "shallow " line, which was an unfortunate mistake we cannot retroactively fix with existing receive-pack already deployed in the field) and we set it to "true" with cmds_sent++, not because we care about the actual number of updates sent but because it is merely an idiomatic way. Set it explicitly to one to clarify that the code that uses this variable only cares about its zero-ness. Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--send-pack.c7
1 files changed, 4 insertions, 3 deletions
diff --git a/send-pack.c b/send-pack.c
index 6dc8a460c2..bb13599c33 100644
--- a/send-pack.c
+++ b/send-pack.c
@@ -304,15 +304,16 @@ int send_pack(struct send_pack_args *args,
old_hex = sha1_to_hex(ref->old_sha1);
new_hex = sha1_to_hex(ref->new_sha1);
- if (!cmds_sent)
+ if (!cmds_sent) {
packet_buf_write(&req_buf,
"%s %s %s%c%s",
old_hex, new_hex, ref->name, 0,
cap_buf.buf);
- else
+ cmds_sent = 1;
+ } else {
packet_buf_write(&req_buf, "%s %s %s",
old_hex, new_hex, ref->name);
- cmds_sent++;
+ }
}
if (args->stateless_rpc) {