diff options
Diffstat (limited to 'libjava/classpath/gnu/classpath/jdwp/event/filters')
7 files changed, 24 insertions, 17 deletions
diff --git a/libjava/classpath/gnu/classpath/jdwp/event/filters/ClassMatchFilter.java b/libjava/classpath/gnu/classpath/jdwp/event/filters/ClassMatchFilter.java index 4ee92bbf5e1..62a3a74fe54 100644 --- a/libjava/classpath/gnu/classpath/jdwp/event/filters/ClassMatchFilter.java +++ b/libjava/classpath/gnu/classpath/jdwp/event/filters/ClassMatchFilter.java @@ -41,7 +41,6 @@ package gnu.classpath.jdwp.event.filters; import gnu.classpath.jdwp.event.Event; import gnu.classpath.jdwp.exception.InvalidStringException; -import gnu.classpath.jdwp.exception.InvalidClassException; import gnu.classpath.jdwp.id.ReferenceTypeId; /** diff --git a/libjava/classpath/gnu/classpath/jdwp/event/filters/ConditionalFilter.java b/libjava/classpath/gnu/classpath/jdwp/event/filters/ConditionalFilter.java index 1fab693eee7..645a70f42b7 100644 --- a/libjava/classpath/gnu/classpath/jdwp/event/filters/ConditionalFilter.java +++ b/libjava/classpath/gnu/classpath/jdwp/event/filters/ConditionalFilter.java @@ -61,7 +61,7 @@ public class ConditionalFilter * <p><b>NOTE:</b> This filter is marked "for the future", * i.e, there is no way to actually use this yet. * - * @param cond the conditional expression + * @param conditional the conditional expression * @throws NotImplementedException if used */ public ConditionalFilter (Object conditional) diff --git a/libjava/classpath/gnu/classpath/jdwp/event/filters/ExceptionOnlyFilter.java b/libjava/classpath/gnu/classpath/jdwp/event/filters/ExceptionOnlyFilter.java index cc4919de6ab..cf6c0704daf 100644 --- a/libjava/classpath/gnu/classpath/jdwp/event/filters/ExceptionOnlyFilter.java +++ b/libjava/classpath/gnu/classpath/jdwp/event/filters/ExceptionOnlyFilter.java @@ -59,11 +59,11 @@ public class ExceptionOnlyFilter private boolean _uncaught; /** - * Constructs a new <code>ExceptionOnlyFilter</code> + * Constructs a new ExceptionOnlyFilter * - * @param refid - * @param caught - * @param uncaught + * @param refId ID of the exception to report + * @param caught Report caught exceptions + * @param uncaught Report uncaught exceptions * @throws InvalidClassException if refid is invalid */ public ExceptionOnlyFilter (ReferenceTypeId refId, boolean caught, diff --git a/libjava/classpath/gnu/classpath/jdwp/event/filters/FieldOnlyFilter.java b/libjava/classpath/gnu/classpath/jdwp/event/filters/FieldOnlyFilter.java index 19c5b8a9ba1..20a9edf2237 100644 --- a/libjava/classpath/gnu/classpath/jdwp/event/filters/FieldOnlyFilter.java +++ b/libjava/classpath/gnu/classpath/jdwp/event/filters/FieldOnlyFilter.java @@ -64,7 +64,7 @@ public class FieldOnlyFilter * @param refId class for field * @param fid field * @throws InvalidClassException if class is invalid - * @throws InvalidFieldExcpetion if field is invalid + * @throws InvalidFieldException if field is invalid */ public FieldOnlyFilter (ReferenceTypeId refId, /*Field*/ReferenceTypeId fid) throws InvalidClassException, InvalidFieldException diff --git a/libjava/classpath/gnu/classpath/jdwp/event/filters/LocationOnlyFilter.java b/libjava/classpath/gnu/classpath/jdwp/event/filters/LocationOnlyFilter.java index e9102fa0303..7190317a4ae 100644 --- a/libjava/classpath/gnu/classpath/jdwp/event/filters/LocationOnlyFilter.java +++ b/libjava/classpath/gnu/classpath/jdwp/event/filters/LocationOnlyFilter.java @@ -1,5 +1,5 @@ /* LocationOnlyFilter.java -- filter on location - Copyright (C) 2005 Free Software Foundation + Copyright (C) 2005, 2006 Free Software Foundation This file is part of GNU Classpath. @@ -49,6 +49,13 @@ import gnu.classpath.jdwp.util.Location; * May be used with breakpoint, field access, field modification, step, * and exception event kinds. * + * This "filter" is not really a filter. It is simply a way to communicate + * location information for supported events in a generic way to ease + * the burden of special casing several things in + * EventReqeustCommandSet.executeSet. + * + * Consequently, this "filter" always matches any event. + * * @author Keith Seitz (keiths@redhat.com) */ public class LocationOnlyFilter @@ -85,7 +92,7 @@ public class LocationOnlyFilter */ public boolean matches (Event event) { - // FIXME - throw new RuntimeException ("LocationOnlyFilter.matches not implemented"); + // This filter always matches. See comments in class javadoc. + return true; } } diff --git a/libjava/classpath/gnu/classpath/jdwp/event/filters/StepFilter.java b/libjava/classpath/gnu/classpath/jdwp/event/filters/StepFilter.java index d029e61e10d..340546e887d 100644 --- a/libjava/classpath/gnu/classpath/jdwp/event/filters/StepFilter.java +++ b/libjava/classpath/gnu/classpath/jdwp/event/filters/StepFilter.java @@ -44,9 +44,9 @@ import gnu.classpath.jdwp.exception.InvalidThreadException; import gnu.classpath.jdwp.id.ThreadId; /** - * An event filter which restricts reported step events to those which + * "An event filter which restricts reported step events to those which * satisfy depth and size constraints. This modifier can only be used with - * step event kinds. + * step event kinds." * * @author Keith Seitz (keiths@redhat.com) */ @@ -58,9 +58,11 @@ public class StepFilter private int _depth; /** - * Constructs a new <code>StepFilter</code> with the given count. + * Constructs a new StepFilter * - * @param count the number of times the event will be ignored + * @param tid ID of the thread in which to step + * @param size size of each step + * @param depth relative call stack limit * @throws InvalidThreadException if thread is invalid */ public StepFilter (ThreadId tid, int size, int depth) @@ -88,7 +90,7 @@ public class StepFilter * Returns the size of each step (insn, line) * * @return the step size - * @see JdwpConstants.StepSize + * @see gnu.classpath.jdwp.JdwpConstants.StepSize */ public int getSize () { @@ -99,7 +101,7 @@ public class StepFilter * Returns the relative call stack limit (into, over, out) * * @return how to step - * @see JdwpConstants.StepDepth + * @see gnu.classpath.jdwp.JdwpConstants.StepDepth */ public int getDepth () { diff --git a/libjava/classpath/gnu/classpath/jdwp/event/filters/ThreadOnlyFilter.java b/libjava/classpath/gnu/classpath/jdwp/event/filters/ThreadOnlyFilter.java index 83ad4094660..2c7a0f1359e 100644 --- a/libjava/classpath/gnu/classpath/jdwp/event/filters/ThreadOnlyFilter.java +++ b/libjava/classpath/gnu/classpath/jdwp/event/filters/ThreadOnlyFilter.java @@ -39,7 +39,6 @@ exception statement from your version. */ package gnu.classpath.jdwp.event.filters; -import gnu.classpath.jdwp.Jdwp; import gnu.classpath.jdwp.event.Event; import gnu.classpath.jdwp.exception.InvalidThreadException; import gnu.classpath.jdwp.id.ThreadId; |