summaryrefslogtreecommitdiff
path: root/libiberty
diff options
context:
space:
mode:
authorian <ian@138bc75d-0d04-0410-961f-82ee72b054a4>2006-09-22 13:52:29 +0000
committerian <ian@138bc75d-0d04-0410-961f-82ee72b054a4>2006-09-22 13:52:29 +0000
commit0b2d8352d25730408e9bfbbd5df7fca31d0fab82 (patch)
tree4025b693fa73085b7f98c46439100a9b1d9680cc /libiberty
parent9a28c8460662b1cfee787f039a33cf45e5fe843f (diff)
downloadgcc-0b2d8352d25730408e9bfbbd5df7fca31d0fab82.tar.gz
PR other/29176
* cp-demangle.c (d_substitution): Check for overflow when computing substitution index. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@117144 138bc75d-0d04-0410-961f-82ee72b054a4
Diffstat (limited to 'libiberty')
-rw-r--r--libiberty/ChangeLog6
-rw-r--r--libiberty/cp-demangle.c2
-rw-r--r--libiberty/testsuite/demangle-expected5
3 files changed, 13 insertions, 0 deletions
diff --git a/libiberty/ChangeLog b/libiberty/ChangeLog
index 0705a14a5f0..5081525fc76 100644
--- a/libiberty/ChangeLog
+++ b/libiberty/ChangeLog
@@ -1,3 +1,9 @@
+2006-09-22 Ian Lance Taylor <ian@airs.com>
+
+ PR other/29176
+ * cp-demangle.c (d_substitution): Check for overflow when
+ computing substitution index.
+
2006-08-30 Corinna Vinschen <corinna@vinschen.de>
* configure.ac: Add case for Mingw as host.
diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c
index c7ee8786d92..2fa59785f2f 100644
--- a/libiberty/cp-demangle.c
+++ b/libiberty/cp-demangle.c
@@ -2505,6 +2505,8 @@ d_substitution (struct d_info *di, int prefix)
id = id * 36 + c - 'A' + 10;
else
return NULL;
+ if (id < 0)
+ return NULL;
c = d_next_char (di);
}
while (c != '_');
diff --git a/libiberty/testsuite/demangle-expected b/libiberty/testsuite/demangle-expected
index 4aaa3d639ec..3f5622f79b7 100644
--- a/libiberty/testsuite/demangle-expected
+++ b/libiberty/testsuite/demangle-expected
@@ -3811,3 +3811,8 @@ make<Factory, int>
_Z1fM1AKiPKS1_
f(int const A::*, int const A::* const*)
f
+# This used to cause a core dump in the demangler -- PR 29176
+--format=auto --no-params
+SASDASDFASDF_sdfsdf
+SASDASDFASDF_sdfsdf
+SASDASDFASDF_sdfsdf