diff options
| author | David Malcolm <dmalcolm@redhat.com> | 2018-09-17 23:32:12 +0000 |
|---|---|---|
| committer | David Malcolm <dmalcolm@gcc.gnu.org> | 2018-09-17 23:32:12 +0000 |
| commit | 9c4a4b3cbd4970447d28963481c04bb7b7d2c4f2 (patch) | |
| tree | c99eac9e12ee799efbd01d27abbba880659e4241 /libcpp | |
| parent | 71b731be7a9fa2b92ee63abeb48900008902f7a6 (diff) | |
| download | gcc-9c4a4b3cbd4970447d28963481c04bb7b7d2c4f2.tar.gz | |
Add range_idx param to range_label::get_text
This patch updates the pure virtual function range_label::get_text
(and its implementations) so that the index of the range is passed
in, allowing for one label instance to be shared by multiple ranges.
gcc/c-family/ChangeLog:
* c-format.c (range_label_for_format_type_mismatch::get_text):
Update for new param.
gcc/c/ChangeLog:
* c-objc-common.c (range_label_for_type_mismatch::get_text):
Update for new param.
* c-typeck.c (maybe_range_label_for_tree_type_mismatch::get_text):
Likewise.
gcc/cp/ChangeLog:
* error.c (range_label_for_type_mismatch::get_text): Update for
new param.
gcc/ChangeLog:
* diagnostic-show-locus.c (class layout_range): Add field
"m_original_idx".
(layout_range::layout_range): Add "original_idx" param and use it
to initialize new field.
(make_range): Use 0 for original_idx.
(layout::layout): Pass in index to calls to
maybe_add_location_range.
(layout::maybe_add_location_range): Add param "original_idx" and
pass it on to layout_range.
(layout::print_any_labels): Pass on range->m_original_idx to
get_text call.
(gcc_rich_location::add_location_if_nearby): Use 0 for
original_idx.
* gcc-rich-location.h (text_range_label::get_text): Update for new
param.
(range_label_for_type_mismatch::get_text): Likewise.
libcpp/ChangeLog:
* include/line-map.h (range_label::get_text): Add param
"range_idx".
From-SVN: r264376
Diffstat (limited to 'libcpp')
| -rw-r--r-- | libcpp/ChangeLog | 5 | ||||
| -rw-r--r-- | libcpp/include/line-map.h | 6 |
2 files changed, 9 insertions, 2 deletions
diff --git a/libcpp/ChangeLog b/libcpp/ChangeLog index 59052be1ba6..ef96824f7ef 100644 --- a/libcpp/ChangeLog +++ b/libcpp/ChangeLog @@ -1,3 +1,8 @@ +2018-09-17 David Malcolm <dmalcolm@redhat.com> + + * include/line-map.h (range_label::get_text): Add param + "range_idx". + 2018-08-30 Nathan Sidwell <nathan@acm.org> * include/line-map.h (enum lc_reason): Comment each member diff --git a/libcpp/include/line-map.h b/libcpp/include/line-map.h index fd067589b63..c479dfa2b3c 100644 --- a/libcpp/include/line-map.h +++ b/libcpp/include/line-map.h @@ -1808,8 +1808,10 @@ class range_label public: virtual ~range_label () {} - /* Get localized text for the label. */ - virtual label_text get_text () const = 0; + /* Get localized text for the label. + The RANGE_IDX is provided, allowing for range_label instances to be + shared by multiple ranges if need be (the "flyweight" design pattern). */ + virtual label_text get_text (unsigned range_idx) const = 0; }; /* A fix-it hint: a suggested insertion, replacement, or deletion of text. |