summaryrefslogtreecommitdiff
path: root/gcc
diff options
context:
space:
mode:
authorjason <jason@138bc75d-0d04-0410-961f-82ee72b054a4>2011-06-07 15:09:29 +0000
committerjason <jason@138bc75d-0d04-0410-961f-82ee72b054a4>2011-06-07 15:09:29 +0000
commit9fd75d525b510af57a2ca7a536a18930506e2cd1 (patch)
tree7b362ff7ad48bea5b1140d97d5790865a4121aeb /gcc
parente4701ee934076ca4197c73d16fe42cff12e2b158 (diff)
downloadgcc-9fd75d525b510af57a2ca7a536a18930506e2cd1.tar.gz
PR c++/48780
* typeck.c (perform_integral_promotions): Don't promote scoped enums. * call.c (convert_arg_to_ellipsis): Promote them here in old ABI. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@174751 138bc75d-0d04-0410-961f-82ee72b054a4
Diffstat (limited to 'gcc')
-rw-r--r--gcc/cp/ChangeLog6
-rw-r--r--gcc/cp/call.c10
-rw-r--r--gcc/cp/cvt.c3
-rw-r--r--gcc/cp/typeck.c3
-rw-r--r--gcc/testsuite/ChangeLog4
-rw-r--r--gcc/testsuite/g++.dg/cpp0x/enum19.C12
6 files changed, 36 insertions, 2 deletions
diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index c3826e5559c..ba3fd1a3f0c 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,9 @@
+2011-06-06 Jason Merrill <jason@redhat.com>
+
+ PR c++/48780
+ * typeck.c (perform_integral_promotions): Don't promote scoped enums.
+ * call.c (convert_arg_to_ellipsis): Promote them here in old ABI.
+
2011-06-06 Nicola Pero <nicola.pero@meta-innovation.com>,
PR obj-c++/48275
diff --git a/gcc/cp/call.c b/gcc/cp/call.c
index ff3dc062b2e..d955b63936c 100644
--- a/gcc/cp/call.c
+++ b/gcc/cp/call.c
@@ -5896,7 +5896,15 @@ convert_arg_to_ellipsis (tree arg)
else if (NULLPTR_TYPE_P (arg_type))
arg = null_pointer_node;
else if (INTEGRAL_OR_ENUMERATION_TYPE_P (arg_type))
- arg = perform_integral_promotions (arg);
+ {
+ if (SCOPED_ENUM_P (arg_type) && !abi_version_at_least (6))
+ {
+ warning (OPT_Wabi, "scoped enum %qT will not promote to an "
+ "integral type in a future version of GCC", arg_type);
+ arg = cp_convert (ENUM_UNDERLYING_TYPE (arg_type), arg);
+ }
+ arg = perform_integral_promotions (arg);
+ }
arg = require_complete_type (arg);
arg_type = TREE_TYPE (arg);
diff --git a/gcc/cp/cvt.c b/gcc/cp/cvt.c
index e5d5361ac28..8a23d5199f6 100644
--- a/gcc/cp/cvt.c
+++ b/gcc/cp/cvt.c
@@ -1616,7 +1616,8 @@ type_promotes_to (tree type)
if (TREE_CODE (type) == BOOLEAN_TYPE)
type = integer_type_node;
- /* scoped enums don't promote. */
+ /* Scoped enums don't promote, but pretend they do for backward ABI bug
+ compatibility wrt varargs. */
else if (SCOPED_ENUM_P (type) && abi_version_at_least (6))
;
diff --git a/gcc/cp/typeck.c b/gcc/cp/typeck.c
index 5fbb765767e..8e4fd4213c3 100644
--- a/gcc/cp/typeck.c
+++ b/gcc/cp/typeck.c
@@ -1953,6 +1953,9 @@ perform_integral_promotions (tree expr)
if (!type || TREE_CODE (type) != ENUMERAL_TYPE)
type = TREE_TYPE (expr);
gcc_assert (INTEGRAL_OR_ENUMERATION_TYPE_P (type));
+ /* Scoped enums don't promote. */
+ if (SCOPED_ENUM_P (type))
+ return expr;
promoted_type = type_promotes_to (type);
if (type != promoted_type)
expr = cp_convert (promoted_type, expr);
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index 05849cc82dd..b38cd1e6770 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2011-06-06 Jason Merrill <jason@redhat.com>
+
+ * g++.dg/cpp0x/enum19.C: New.
+
2011-06-07 Sergey Grechanik <mouseentity@ispras.ru>
* gcc.target/arm/neon-reload-class.c: New test.
diff --git a/gcc/testsuite/g++.dg/cpp0x/enum19.C b/gcc/testsuite/g++.dg/cpp0x/enum19.C
new file mode 100644
index 00000000000..acdd86c0ba4
--- /dev/null
+++ b/gcc/testsuite/g++.dg/cpp0x/enum19.C
@@ -0,0 +1,12 @@
+// We shouldn't give an ABI warning about promotion in switch.
+// { dg-options "-std=c++0x -fabi-version=5 -Wabi" }
+
+enum class Foo { X };
+void test(Foo val)
+{
+ switch(val)
+ {
+ case Foo::X:
+ break;
+ }
+};