summaryrefslogtreecommitdiff
path: root/contrib
diff options
context:
space:
mode:
authordevans <devans@138bc75d-0d04-0410-961f-82ee72b054a4>2012-11-29 21:23:22 +0000
committerdevans <devans@138bc75d-0d04-0410-961f-82ee72b054a4>2012-11-29 21:23:22 +0000
commitb1a8f0637c63a6fe5b0f1a2e18f7840d855bf180 (patch)
tree2882599c73bb8fa289621b3797b42fb6d9ddf5a2 /contrib
parent3c3f480eb1c70f05275cdf3cb45f7bce9780ad8d (diff)
downloadgcc-b1a8f0637c63a6fe5b0f1a2e18f7840d855bf180.tar.gz
* testsuite-management/validate_failures.py: Rename variable
manifest_name to manifest_path everywhere. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@193965 138bc75d-0d04-0410-961f-82ee72b054a4
Diffstat (limited to 'contrib')
-rw-r--r--contrib/ChangeLog3
-rwxr-xr-xcontrib/testsuite-management/validate_failures.py26
2 files changed, 16 insertions, 13 deletions
diff --git a/contrib/ChangeLog b/contrib/ChangeLog
index 91520b90b11..386fd81c6a5 100644
--- a/contrib/ChangeLog
+++ b/contrib/ChangeLog
@@ -1,5 +1,8 @@
2012-11-29 Doug Evans <dje@google.com>
+ * testsuite-management/validate_failures.py: Rename variable
+ manifest_name to manifest_path everywhere.
+
* testsuite-management/validate_failures.py (CompareBuilds): Pass
options.results to GetSumFiles for clean build.
diff --git a/contrib/testsuite-management/validate_failures.py b/contrib/testsuite-management/validate_failures.py
index 60c275b46d4..d9eb7319e38 100755
--- a/contrib/testsuite-management/validate_failures.py
+++ b/contrib/testsuite-management/validate_failures.py
@@ -220,7 +220,7 @@ def ParseSummary(sum_fname):
return result_set
-def GetManifest(manifest_name):
+def GetManifest(manifest_path):
"""Build a set of expected failures from the manifest file.
Each entry in the manifest file should have the format understood
@@ -228,8 +228,8 @@ def GetManifest(manifest_name):
If no manifest file exists for this target, it returns an empty set.
"""
- if os.path.exists(manifest_name):
- return ParseSummary(manifest_name)
+ if os.path.exists(manifest_path):
+ return ParseManifest(manifest_path)
else:
return set()
@@ -334,14 +334,14 @@ def CheckExpectedResults(options):
(srcdir, target, valid_build) = GetBuildData(options)
if not valid_build:
return False
- manifest_name = _MANIFEST_PATH_PATTERN % (srcdir, target)
+ manifest_path = _MANIFEST_PATH_PATTERN % (srcdir, target)
else:
- manifest_name = options.manifest
- if not os.path.exists(manifest_name):
- Error('Manifest file %s does not exist.' % manifest_name)
+ manifest_path = options.manifest
+ if not os.path.exists(manifest_path):
+ Error('Manifest file %s does not exist.' % manifest_path)
- print 'Manifest: %s' % manifest_name
- manifest = GetManifest(manifest_name)
+ print 'Manifest: %s' % manifest_path
+ manifest = GetManifest(manifest_path)
sum_files = GetSumFiles(options.results, options.build_dir)
actual = GetResults(sum_files)
@@ -357,14 +357,14 @@ def ProduceManifest(options):
if not valid_build:
return False
- manifest_name = _MANIFEST_PATH_PATTERN % (srcdir, target)
- if os.path.exists(manifest_name) and not options.force:
+ manifest_path = _MANIFEST_PATH_PATTERN % (srcdir, target)
+ if os.path.exists(manifest_path) and not options.force:
Error('Manifest file %s already exists.\nUse --force to overwrite.' %
- manifest_name)
+ manifest_path)
sum_files = GetSumFiles(options.results, options.build_dir)
actual = GetResults(sum_files)
- manifest_file = open(manifest_name, 'w')
+ manifest_file = open(manifest_path, 'w')
for result in sorted(actual):
print result
manifest_file.write('%s\n' % result)