summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorbothner <bothner@138bc75d-0d04-0410-961f-82ee72b054a4>2001-03-24 00:59:57 +0000
committerbothner <bothner@138bc75d-0d04-0410-961f-82ee72b054a4>2001-03-24 00:59:57 +0000
commit85dee3e86c19116d1129c6d556cbbd6231c1d252 (patch)
treefafc2f660ada28148b694ca4afb1638030488771
parent45cb76f4145003d0f08392064a40452ced0cf59a (diff)
downloadgcc-85dee3e86c19116d1129c6d556cbbd6231c1d252.tar.gz
* java/lang/natDouble.cc (parseDouble): Cannot use errno to
check for errors, since we don't want to throw exception on overflow/underflow. Instead, trim whitespace, and then check that _strtod_r uses up all the rest of the string. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@40800 138bc75d-0d04-0410-961f-82ee72b054a4
-rw-r--r--libjava/java/lang/natDouble.cc40
1 files changed, 25 insertions, 15 deletions
diff --git a/libjava/java/lang/natDouble.cc b/libjava/java/lang/natDouble.cc
index 9ed7e53910d..af2d70ad6f3 100644
--- a/libjava/java/lang/natDouble.cc
+++ b/libjava/java/lang/natDouble.cc
@@ -15,6 +15,7 @@ details. */
#include <gcj/cni.h>
#include <java/lang/String.h>
#include <java/lang/Double.h>
+#include <java/lang/Character.h>
#include <java/lang/NumberFormatException.h>
#include <jvm.h>
@@ -160,19 +161,28 @@ jdouble
java::lang::Double::parseDouble(jstring str)
{
int length = str->length();
- // Note that UTF can expand 3x.
-
- char *data = (char *) __builtin_alloca (3 * length + 1);
-
- data[_Jv_GetStringUTFRegion (str, 0, length, data)] = 0;
-
- struct _Jv_reent reent;
- memset (&reent, 0, sizeof reent);
-
- double val = _strtod_r (&reent, data, NULL);
-
- if (reent._errno)
- _Jv_Throw (new NumberFormatException);
-
- return val;
+ while (length > 0
+ && Character::isWhitespace(str->charAt(length - 1)))
+ length--;
+ jsize start = 0;
+ while (length > 0
+ && Character::isWhitespace(str->charAt(start)))
+ start++, length--;
+
+ if (length > 0)
+ {
+ // Note that UTF can expand 3x.
+ char *data = (char *) __builtin_alloca (3 * length + 1);
+ jsize blength = _Jv_GetStringUTFRegion (str, start, length, data);
+ data[blength] = 0;
+
+ struct _Jv_reent reent;
+ memset (&reent, 0, sizeof reent);
+
+ char *endptr;
+ double val = _strtod_r (&reent, data, &endptr);
+ if (endptr == data + blength)
+ return val;
+ }
+ _Jv_Throw (new NumberFormatException);
}