diff options
author | rguenth <rguenth@138bc75d-0d04-0410-961f-82ee72b054a4> | 2017-06-22 11:46:45 +0000 |
---|---|---|
committer | rguenth <rguenth@138bc75d-0d04-0410-961f-82ee72b054a4> | 2017-06-22 11:46:45 +0000 |
commit | 3e01365d57bf10c6fadb0591e71627a82a812ad4 (patch) | |
tree | 550419cdbbb6d9820ffecb871f9d806cf6410558 | |
parent | 947ddb5aad02abeed2e869cd65f6e4e64816f017 (diff) | |
download | gcc-3e01365d57bf10c6fadb0591e71627a82a812ad4.tar.gz |
2017-06-22 Richard Biener <rguenther@suse.de>
Backport from mainline
2017-02-17 Richard Biener <rguenther@suse.de>
PR tree-optimization/79552
* tree-ssa-structalias.c (visit_loadstore): Properly verify
default defs.
2016-04-18 Richard Biener <rguenther@suse.de>
PR tree-optimization/43434
* tree-ssa-structalias.c (struct vls_data): New.
(visit_loadstore): Handle all pointer-based accesses.
(compute_dependence_clique): Compute a bitmap of restrict tags
assigned bases and pass it to visit_loadstore.
* gcc.dg/vect/pr43434.c: New testcase.
* c-c++-common/goacc/kernels-alias-3.c: Adjust.
* c-c++-common/goacc/kernels-alias-4.c: Likewise.
* c-c++-common/goacc/kernels-alias-5.c: Likewise.
* c-c++-common/goacc/kernels-alias-6.c: Likewise.
* c-c++-common/goacc/kernels-alias-7.c: Likewise.
* c-c++-common/goacc/kernels-alias-8.c: Likewise.
* gcc.dg/gomp/pr68640.c: Likewise.
* gfortran.dg/goacc/kernels-alias-3.f95: Likewise.
* gfortran.dg/goacc/kernels-alias-4.f95: Likewise.
git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gcc-6-branch@249552 138bc75d-0d04-0410-961f-82ee72b054a4
-rw-r--r-- | gcc/ChangeLog | 17 | ||||
-rw-r--r-- | gcc/testsuite/ChangeLog | 17 | ||||
-rw-r--r-- | gcc/testsuite/c-c++-common/goacc/kernels-alias-3.c | 5 | ||||
-rw-r--r-- | gcc/testsuite/c-c++-common/goacc/kernels-alias-4.c | 5 | ||||
-rw-r--r-- | gcc/testsuite/c-c++-common/goacc/kernels-alias-5.c | 2 | ||||
-rw-r--r-- | gcc/testsuite/c-c++-common/goacc/kernels-alias-6.c | 2 | ||||
-rw-r--r-- | gcc/testsuite/c-c++-common/goacc/kernels-alias-7.c | 2 | ||||
-rw-r--r-- | gcc/testsuite/c-c++-common/goacc/kernels-alias-8.c | 2 | ||||
-rw-r--r-- | gcc/testsuite/gcc.dg/gomp/pr68640.c | 2 | ||||
-rw-r--r-- | gcc/testsuite/gfortran.dg/goacc/kernels-alias-3.f95 | 2 | ||||
-rw-r--r-- | gcc/testsuite/gfortran.dg/goacc/kernels-alias-4.f95 | 2 | ||||
-rw-r--r-- | gcc/tree-ssa-structalias.c | 86 |
12 files changed, 103 insertions, 41 deletions
diff --git a/gcc/ChangeLog b/gcc/ChangeLog index eacdaacadf6..cb4dc8bf7a7 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,20 @@ +2017-06-22 Richard Biener <rguenther@suse.de> + + Backport from mainline + 2017-02-17 Richard Biener <rguenther@suse.de> + + PR tree-optimization/79552 + * tree-ssa-structalias.c (visit_loadstore): Properly verify + default defs. + + 2016-04-18 Richard Biener <rguenther@suse.de> + + PR tree-optimization/43434 + * tree-ssa-structalias.c (struct vls_data): New. + (visit_loadstore): Handle all pointer-based accesses. + (compute_dependence_clique): Compute a bitmap of restrict tags + assigned bases and pass it to visit_loadstore. + 2017-06-22 Jakub Jelinek <jakub@redhat.com> Backported from mainline diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index cd051e41b43..0ae1c09c754 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,20 @@ +2017-06-22 Richard Biener <rguenther@suse.de> + + Backport from mainline + 2016-04-18 Richard Biener <rguenther@suse.de> + + PR tree-optimization/43434 + * gcc.dg/vect/pr43434.c: New testcase. + * c-c++-common/goacc/kernels-alias-3.c: Adjust. + * c-c++-common/goacc/kernels-alias-4.c: Likewise. + * c-c++-common/goacc/kernels-alias-5.c: Likewise. + * c-c++-common/goacc/kernels-alias-6.c: Likewise. + * c-c++-common/goacc/kernels-alias-7.c: Likewise. + * c-c++-common/goacc/kernels-alias-8.c: Likewise. + * gcc.dg/gomp/pr68640.c: Likewise. + * gfortran.dg/goacc/kernels-alias-3.f95: Likewise. + * gfortran.dg/goacc/kernels-alias-4.f95: Likewise. + 2017-06-22 Jakub Jelinek <jakub@redhat.com> Backported from mainline diff --git a/gcc/testsuite/c-c++-common/goacc/kernels-alias-3.c b/gcc/testsuite/c-c++-common/goacc/kernels-alias-3.c index 0eda7e17c3b..6989c1c1b6d 100644 --- a/gcc/testsuite/c-c++-common/goacc/kernels-alias-3.c +++ b/gcc/testsuite/c-c++-common/goacc/kernels-alias-3.c @@ -14,7 +14,8 @@ foo (void) } } -/* Only the omp_data_i related loads should be annotated with cliques. */ +/* Only the omp_data_i related loads should be annotated with + non-base 0 cliques. */ /* { dg-final { scan-tree-dump-times "clique 1 base 1" 2 "ealias" } } */ -/* { dg-final { scan-tree-dump-times "(?n)clique .* base .*" 2 "ealias" } } */ +/* { dg-final { scan-tree-dump-times "(?n)clique 1 base 0" 3 "ealias" } } */ diff --git a/gcc/testsuite/c-c++-common/goacc/kernels-alias-4.c b/gcc/testsuite/c-c++-common/goacc/kernels-alias-4.c index 037901fcffb..d41802c00db 100644 --- a/gcc/testsuite/c-c++-common/goacc/kernels-alias-4.c +++ b/gcc/testsuite/c-c++-common/goacc/kernels-alias-4.c @@ -16,7 +16,8 @@ foo (void) } } -/* Only the omp_data_i related loads should be annotated with cliques. */ +/* Only the omp_data_i related loads should be annotated with + non-base 0 cliques. */ /* { dg-final { scan-tree-dump-times "clique 1 base 1" 2 "ealias" } } */ -/* { dg-final { scan-tree-dump-times "(?n)clique .* base .*" 2 "ealias" } } */ +/* { dg-final { scan-tree-dump-times "(?n)clique 1 base 0" 3 "ealias" } } */ diff --git a/gcc/testsuite/c-c++-common/goacc/kernels-alias-5.c b/gcc/testsuite/c-c++-common/goacc/kernels-alias-5.c index 69cd3fb9449..6fefe183203 100644 --- a/gcc/testsuite/c-c++-common/goacc/kernels-alias-5.c +++ b/gcc/testsuite/c-c++-common/goacc/kernels-alias-5.c @@ -15,5 +15,5 @@ foo (int *a) /* Only the omp_data_i related loads should be annotated with cliques. */ /* { dg-final { scan-tree-dump-times "clique 1 base 1" 2 "ealias" } } */ -/* { dg-final { scan-tree-dump-times "(?n)clique .* base .*" 2 "ealias" } } */ +/* { dg-final { scan-tree-dump-times "(?n)clique 1 base 0" 4 "ealias" } } */ diff --git a/gcc/testsuite/c-c++-common/goacc/kernels-alias-6.c b/gcc/testsuite/c-c++-common/goacc/kernels-alias-6.c index 6ebce15f5e2..908e1cafd71 100644 --- a/gcc/testsuite/c-c++-common/goacc/kernels-alias-6.c +++ b/gcc/testsuite/c-c++-common/goacc/kernels-alias-6.c @@ -19,5 +19,5 @@ foo (void) /* Only the omp_data_i related loads should be annotated with cliques. */ /* { dg-final { scan-tree-dump-times "clique 1 base 1" 2 "ealias" } } */ -/* { dg-final { scan-tree-dump-times "(?n)clique .* base .*" 2 "ealias" } } */ +/* { dg-final { scan-tree-dump-times "(?n)clique 1 base 0" 3 "ealias" } } */ diff --git a/gcc/testsuite/c-c++-common/goacc/kernels-alias-7.c b/gcc/testsuite/c-c++-common/goacc/kernels-alias-7.c index 40eb235d601..923d00239a2 100644 --- a/gcc/testsuite/c-c++-common/goacc/kernels-alias-7.c +++ b/gcc/testsuite/c-c++-common/goacc/kernels-alias-7.c @@ -21,5 +21,5 @@ foo (void) /* Only the omp_data_i related loads should be annotated with cliques. */ /* { dg-final { scan-tree-dump-times "clique 1 base 1" 2 "ealias" } } */ -/* { dg-final { scan-tree-dump-times "(?n)clique .* base .*" 2 "ealias" } } */ +/* { dg-final { scan-tree-dump-times "(?n)clique 1 base 0" 3 "ealias" } } */ diff --git a/gcc/testsuite/c-c++-common/goacc/kernels-alias-8.c b/gcc/testsuite/c-c++-common/goacc/kernels-alias-8.c index 0b93e35909b..3b91acd27f5 100644 --- a/gcc/testsuite/c-c++-common/goacc/kernels-alias-8.c +++ b/gcc/testsuite/c-c++-common/goacc/kernels-alias-8.c @@ -18,5 +18,5 @@ foo (int *a, size_t n) /* Only the omp_data_i related loads should be annotated with cliques. */ /* { dg-final { scan-tree-dump-times "clique 1 base 1" 2 "ealias" } } */ -/* { dg-final { scan-tree-dump-times "(?n)clique .* base .*" 2 "ealias" } } */ +/* { dg-final { scan-tree-dump-times "(?n)clique 1 base 0" 3 "ealias" } } */ diff --git a/gcc/testsuite/gcc.dg/gomp/pr68640.c b/gcc/testsuite/gcc.dg/gomp/pr68640.c index f333db0923a..d2b1b472140 100644 --- a/gcc/testsuite/gcc.dg/gomp/pr68640.c +++ b/gcc/testsuite/gcc.dg/gomp/pr68640.c @@ -13,4 +13,4 @@ foo (int *__restrict__ ap) } /* { dg-final { scan-tree-dump-times "clique 1 base 1" 2 "ealias" } } */ -/* { dg-final { scan-tree-dump-times "(?n)clique .* base .*" 2 "ealias" } } */ +/* { dg-final { scan-tree-dump-times "(?n)clique 1 base 0" 2 "ealias" } } */ diff --git a/gcc/testsuite/gfortran.dg/goacc/kernels-alias-3.f95 b/gcc/testsuite/gfortran.dg/goacc/kernels-alias-3.f95 index 56f3d598d66..07dc8d6c641 100644 --- a/gcc/testsuite/gfortran.dg/goacc/kernels-alias-3.f95 +++ b/gcc/testsuite/gfortran.dg/goacc/kernels-alias-3.f95 @@ -16,4 +16,4 @@ end program main ! Only the omp_data_i related loads should be annotated with cliques. ! { dg-final { scan-tree-dump-times "clique 1 base 1" 2 "ealias" } } -! { dg-final { scan-tree-dump-times "(?n)clique .* base .*" 2 "ealias" } } +! { dg-final { scan-tree-dump-times "(?n)clique 1 base 0" 3 "ealias" } } diff --git a/gcc/testsuite/gfortran.dg/goacc/kernels-alias-4.f95 b/gcc/testsuite/gfortran.dg/goacc/kernels-alias-4.f95 index e65253b1844..36f7f65fbac 100644 --- a/gcc/testsuite/gfortran.dg/goacc/kernels-alias-4.f95 +++ b/gcc/testsuite/gfortran.dg/goacc/kernels-alias-4.f95 @@ -17,4 +17,4 @@ end program main ! Only the omp_data_i related loads should be annotated with cliques. ! { dg-final { scan-tree-dump-times "clique 1 base 1" 3 "ealias" } } -! { dg-final { scan-tree-dump-times "(?n)clique .* base .*" 3 "ealias" } } +! { dg-final { scan-tree-dump-times "(?n)clique 1 base 0" 4 "ealias" } } diff --git a/gcc/tree-ssa-structalias.c b/gcc/tree-ssa-structalias.c index 07736e33923..0a28739e6f7 100644 --- a/gcc/tree-ssa-structalias.c +++ b/gcc/tree-ssa-structalias.c @@ -7237,26 +7237,43 @@ delete_points_to_sets (void) obstack_free (&final_solutions_obstack, NULL); } +struct vls_data +{ + unsigned short clique; + bitmap rvars; +}; + /* Mark "other" loads and stores as belonging to CLIQUE and with base zero. */ static bool -visit_loadstore (gimple *, tree base, tree ref, void *clique_) +visit_loadstore (gimple *, tree base, tree ref, void *data) { - unsigned short clique = (uintptr_t)clique_; + unsigned short clique = ((vls_data *) data)->clique; + bitmap rvars = ((vls_data *) data)->rvars; if (TREE_CODE (base) == MEM_REF || TREE_CODE (base) == TARGET_MEM_REF) { tree ptr = TREE_OPERAND (base, 0); - if (TREE_CODE (ptr) == SSA_NAME - && ! SSA_NAME_IS_DEFAULT_DEF (ptr)) + if (TREE_CODE (ptr) == SSA_NAME) { - /* ??? We need to make sure 'ptr' doesn't include any of + /* For parameters, get at the points-to set for the actual parm + decl. */ + if (SSA_NAME_IS_DEFAULT_DEF (ptr) + && (TREE_CODE (SSA_NAME_VAR (ptr)) == PARM_DECL + || TREE_CODE (SSA_NAME_VAR (ptr)) == RESULT_DECL)) + ptr = SSA_NAME_VAR (ptr); + + /* We need to make sure 'ptr' doesn't include any of the restrict tags we added bases for in its points-to set. */ - return false; - } + varinfo_t vi = lookup_vi_for_tree (ptr); + if (! vi) + return false; - /* For now let decls through. */ + vi = get_varinfo (find (vi->id)); + if (bitmap_intersect_p (rvars, vi->solution)) + return false; + } /* Do not overwrite existing cliques (that includes clique, base pairs we just set). */ @@ -7330,6 +7347,7 @@ compute_dependence_clique (void) { unsigned short clique = 0; unsigned short last_ruid = 0; + bitmap rvars = BITMAP_ALLOC (NULL); for (unsigned i = 0; i < num_ssa_names; ++i) { tree ptr = ssa_name (i); @@ -7385,38 +7403,46 @@ compute_dependence_clique (void) /* Now look at possible dereferences of ptr. */ imm_use_iterator ui; gimple *use_stmt; + bool used = false; FOR_EACH_IMM_USE_STMT (use_stmt, ui, ptr) { /* ??? Calls and asms. */ if (!gimple_assign_single_p (use_stmt)) continue; - maybe_set_dependence_info (gimple_assign_lhs (use_stmt), ptr, - clique, restrict_var, last_ruid); - maybe_set_dependence_info (gimple_assign_rhs1 (use_stmt), ptr, - clique, restrict_var, last_ruid); + used |= maybe_set_dependence_info (gimple_assign_lhs (use_stmt), + ptr, clique, restrict_var, + last_ruid); + used |= maybe_set_dependence_info (gimple_assign_rhs1 (use_stmt), + ptr, clique, restrict_var, + last_ruid); } + if (used) + bitmap_set_bit (rvars, restrict_var->id); } } - if (clique == 0) - return; + if (clique != 0) + { + /* Assign the BASE id zero to all accesses not based on a restrict + pointer. That way they get disambiguated against restrict + accesses but not against each other. */ + /* ??? For restricts derived from globals (thus not incoming + parameters) we can't restrict scoping properly thus the following + is too aggressive there. For now we have excluded those globals from + getting into the MR_DEPENDENCE machinery. */ + vls_data data = { clique, rvars }; + basic_block bb; + FOR_EACH_BB_FN (bb, cfun) + for (gimple_stmt_iterator gsi = gsi_start_bb (bb); + !gsi_end_p (gsi); gsi_next (&gsi)) + { + gimple *stmt = gsi_stmt (gsi); + walk_stmt_load_store_ops (stmt, &data, + visit_loadstore, visit_loadstore); + } + } - /* Assign the BASE id zero to all accesses not based on a restrict - pointer. That way they get disabiguated against restrict - accesses but not against each other. */ - /* ??? For restricts derived from globals (thus not incoming - parameters) we can't restrict scoping properly thus the following - is too aggressive there. For now we have excluded those globals from - getting into the MR_DEPENDENCE machinery. */ - basic_block bb; - FOR_EACH_BB_FN (bb, cfun) - for (gimple_stmt_iterator gsi = gsi_start_bb (bb); - !gsi_end_p (gsi); gsi_next (&gsi)) - { - gimple *stmt = gsi_stmt (gsi); - walk_stmt_load_store_ops (stmt, (void *)(uintptr_t)clique, - visit_loadstore, visit_loadstore); - } + BITMAP_FREE (rvars); } /* Compute points-to information for every SSA_NAME pointer in the |