summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Jambor <mjambor@suse.cz>2020-01-13 19:13:46 +0100
committerMartin Jambor <mjambor@suse.cz>2020-01-13 19:13:46 +0100
commit8472660b98a31b32b7d030c2cdc4d41d326364d5 (patch)
tree2307143e7fadf723fa137a74f02112cdd0213faa
parent69dc042f91c70458ffb6e7b147f093799cee2100 (diff)
downloadgcc-8472660b98a31b32b7d030c2cdc4d41d326364d5.tar.gz
IPA: Avoid segfault in devirtualization_time_bonus (PR 93223)
2020-01-13 Martin Jambor <mjambor@suse.cz> PR ipa/93223 * ipa-cp.c (devirtualization_time_bonus): Check whether isummary is NULL. testsuite/ * g++.dg/ipa/pr93223.C: New test.
-rw-r--r--gcc/ipa-cp.c2
-rw-r--r--gcc/testsuite/g++.dg/ipa/pr93223.C62
2 files changed, 63 insertions, 1 deletions
diff --git a/gcc/ipa-cp.c b/gcc/ipa-cp.c
index 612f3d0a89b..17da1d8e8a7 100644
--- a/gcc/ipa-cp.c
+++ b/gcc/ipa-cp.c
@@ -3158,7 +3158,7 @@ devirtualization_time_bonus (struct cgraph_node *node,
if (avail < AVAIL_AVAILABLE)
continue;
isummary = ipa_fn_summaries->get (callee);
- if (!isummary->inlinable)
+ if (!isummary || !isummary->inlinable)
continue;
int size = ipa_size_summaries->get (callee)->size;
diff --git a/gcc/testsuite/g++.dg/ipa/pr93223.C b/gcc/testsuite/g++.dg/ipa/pr93223.C
new file mode 100644
index 00000000000..87f98b5e244
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ipa/pr93223.C
@@ -0,0 +1,62 @@
+/* { dg-do compile } */
+/* { dg-options "-O3 -std=gnu++14" } */
+
+template <typename Function>
+bool run(const int item_count,
+ Function && process_range,
+ const int max_parallelism,
+ int* progress = nullptr)
+{
+ if (max_parallelism <= 1)
+ {
+ if (progress == nullptr)
+ {
+ return process_range(0);
+ }
+ else
+ {
+ auto result = true;
+ for (int i = 0; i != item_count && result; ++i)
+ {
+ (*progress)++;
+ result = process_range(i);
+ }
+ return result;
+ }
+ }
+
+ if (max_parallelism > 10)
+ {
+ if (progress == nullptr)
+ {
+ return process_range(0);
+ }
+ else
+ {
+ auto result = true;
+ for (int i = 0; i != item_count && result; ++i)
+ {
+ (*progress)++;
+ result = process_range(i);
+ }
+ return result;
+ }
+ }
+ return false;
+}
+
+namespace
+{
+__attribute__((optimize(0))) bool worker_fun(const int)
+{
+ return true;
+}
+}
+
+void demo(int n)
+{
+ for (int i = 0; i < n; ++i)
+ {
+ run(n, &worker_fun, n);
+ }
+}